-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/python/bcc/version.py created as part of build #1964
Comments
Yes, this can be easily reproduced. Somehow, when I change branch and did a rebuild. This |
I noticed that as well, but didn't took the time to debug it. I think it's been happening since #1826 got merged. |
Looks like adding that file to |
@pchaigno Adding it to |
@bolinfest Right, it probably would be best to generate that file in |
We could add an entry in |
In some cases the version number might not be what is expected so try to provide proper BCC version strings only. iovisor/bcc#1964
this issue is annoying my builds as well... |
@pchaigno Basically I followed the same approach as it's used for creating Yes, I'll see if I get time in a few days, probably we just need another directory insead of |
@andihit you are actually generating I think just adding |
Sounds good then, could you submit a pull request for this? Could you double check when we do a make clean, we do clean this file as well? Thanks! |
I think this can be close after #1989. |
Just closed the issue! |
I'm on Ubuntu 18.04.1. First, note that the build instructions:
mention Trusty (14.04) and older, so I wasn't sure what to do for 18.04. I ended up copypasta'ing some stuff from the LLVM Debian/Ubuntu nightly packages and created
/etc/apt/sources.list.d/llvm.list
with the following contents:Then I basically followed the existing instructions, but instead of:
I did:
(Note that I originally tried this with
8
instead of7
, but then building bcc failed because thegetLocStart()
API appears to have been renamed in LLVM 8.)Now the problem was getting things to build because everything seems hardcoded for LLVM 3.7. I rooted around in
CMakeLists.txt
and found$LLVM_LIBRARY_DIRS
, so adding an extra argument tocmake
worked fine:However, when I was done,
git status
was not clean, as there was the filesrc/python/bcc/version.py
with the following contents:Not a huge deal, but it would be nice if this file were either not created, created under
build/
, or listed in.gitignore
.It would also be nice if the Ubuntu build instructions were updated to call out what to do for versions after Trusty. Hopefully the record of the steps I went through (and the upcoming breaking in LLVM 8) are useful here.
The text was updated successfully, but these errors were encountered: