Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the base image to easydl/dlrover:ci #722

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Update the base image to easydl/dlrover:ci #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8239dee
Update the base image to easydl/dlrover:ci
workingloong Sep 22, 2023
f53452c
Execute git config in the pre-commit action.
workingloong Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/actions/pre-commit/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ name: pre-commit
description: run pre-commit to check codes
runs:
using: 'docker'
image: "easydl/easydl:ci"
image: "easydl/dlrover:ci"
args:
- "/bin/bash"
- "-c"
- "pre-commit run -a --show-diff-on-failure --color=always"
- "git config --global --add safe.directory '*' && \
pre-commit run -a --show-diff-on-failure --color=always"
2 changes: 1 addition & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM easydl/easydl:ci as builder
FROM easydl/dlrover:ci as builder

WORKDIR /dlrover
COPY ./ .
Expand Down
3 changes: 2 additions & 1 deletion docker/ci.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ COPY docker/scripts/install-protobuf.bash /
RUN /install-protobuf.bash && rm /install-protobuf.bash

# Install Pre-commit
RUN pip install pre-commit pytest -i https://mirrors.aliyun.com/pypi/simple/
RUN pip install pre-commit pytest kubernetes grpcio-tools psutil \
deprecated -i https://mirrors.aliyun.com/pypi/simple/

# Configure envtest for integration tests of kubebuilder
ENV KUBEBUILDER_CONTROLPLANE_START_TIMEOUT 60s
Expand Down
2 changes: 1 addition & 1 deletion examples/pytorch/mnist/mnist.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM easydl/easydl:ci as builder
FROM easydl/dlrover:ci as builder

WORKDIR /dlrover
COPY ./ .
Expand Down
2 changes: 1 addition & 1 deletion examples/pytorch/nanogpt/nanogpt.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM easydl/easydl:ci as builder
FROM easydl/dlrover:ci as builder

WORKDIR /dlrover
COPY ./ .
Expand Down