Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the base image to easydl/dlrover:ci #722

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update the base image to easydl/dlrover:ci
  • Loading branch information
workingloong committed Sep 22, 2023
commit 8239dee8d22f2dba038cb6e761a22a85de4645f3
2 changes: 1 addition & 1 deletion .github/actions/pre-commit/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: pre-commit
description: run pre-commit to check codes
runs:
using: 'docker'
image: "easydl/easydl:ci"
image: "easydl/dlrover:ci"
args:
- "/bin/bash"
- "-c"
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM easydl/easydl:ci as builder
FROM easydl/dlrover:ci as builder

WORKDIR /dlrover
COPY ./ .
Expand Down
3 changes: 2 additions & 1 deletion docker/ci.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ COPY docker/scripts/install-protobuf.bash /
RUN /install-protobuf.bash && rm /install-protobuf.bash

# Install Pre-commit
RUN pip install pre-commit pytest -i https://mirrors.aliyun.com/pypi/simple/
RUN pip install pre-commit pytest kubernetes grpcio-tools psutil \
deprecated -i https://mirrors.aliyun.com/pypi/simple/

# Configure envtest for integration tests of kubebuilder
ENV KUBEBUILDER_CONTROLPLANE_START_TIMEOUT 60s
Expand Down
2 changes: 1 addition & 1 deletion examples/pytorch/mnist/mnist.dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM easydl/easydl:ci as builder
FROM easydl/dlrover:ci as builder

WORKDIR /dlrover
COPY ./ .
Expand Down
2 changes: 1 addition & 1 deletion examples/pytorch/nanogpt/nanogpt.dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM easydl/easydl:ci as builder
FROM easydl/dlrover:ci as builder

WORKDIR /dlrover
COPY ./ .
Expand Down