Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vdp): pipeline run logging query APIs #417

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Aug 9, 2024

  • feat(vdp): Add Paginated List of logged Pipeline Runs Endpoint Because:
  • chore: auto-gen by protobufs
  • feat(vdp): resolved comments

Because:

  • Users need to retrieve pipeline runs efficiently, either for specific pipelines or across all accessible pipelines.

This commit:

  • Returns a paginated list of pipeline runs and components

Copy link

linear bot commented Aug 9, 2024

@joremysh
Copy link
Contributor Author

joremysh commented Aug 9, 2024

almost all the comments at here are resolved @jvallesm

Copy link
Collaborator

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a new PR and addressing the comments. Looks good overall, I left some comments.

vdp/pipeline/v1beta/pipeline_public_service.proto Outdated Show resolved Hide resolved
vdp/pipeline/v1beta/pipeline_public_service.proto Outdated Show resolved Hide resolved
vdp/pipeline/v1beta/pipeline.proto Outdated Show resolved Hide resolved
vdp/pipeline/v1beta/pipeline.proto Show resolved Hide resolved
vdp/pipeline/v1beta/pipeline.proto Show resolved Hide resolved
vdp/pipeline/v1beta/pipeline.proto Outdated Show resolved Hide resolved
vdp/pipeline/v1beta/pipeline.proto Outdated Show resolved Hide resolved
vdp/pipeline/v1beta/pipeline.proto Outdated Show resolved Hide resolved
vdp/pipeline/v1beta/pipeline.proto Outdated Show resolved Hide resolved
@joremysh joremysh force-pushed the jeremy/INS-5274-pipeline-run-logging branch 2 times, most recently from fe56d71 to 49d6a89 Compare August 14, 2024 15:24
tillknuesting and others added 4 commits August 14, 2024 23:26
Because:

- Users need to retrieve pipeline runs efficiently, either for specific pipelines or across all accessible pipelines.

This commit:

- Returns a paginated list of pipeline runs.
- Supports querying for specific pipelines or all accessible pipelines.
- Adds a gRPC method `ListPipelineRuns` with corresponding request and response types.
- Exposes the endpoint via HTTP GET at `/v1beta/pipeline-runs`.
- Tags the endpoint with "PipelineRun" for better API documentation.
@joremysh joremysh force-pushed the jeremy/INS-5274-pipeline-run-logging branch from 49d6a89 to 8a0107e Compare August 14, 2024 15:28
@joremysh joremysh merged commit 2e25657 into main Aug 15, 2024
@joremysh joremysh deleted the jeremy/INS-5274-pipeline-run-logging branch August 15, 2024 03:39
@joremysh
Copy link
Contributor Author

  • confirm with Alex and include schema in response if needed

heiruwu pushed a commit that referenced this pull request Aug 20, 2024
- **feat(vdp): Add Paginated List of logged Pipeline Runs Endpoint
Because:**
- **chore: auto-gen by protobufs**
- **feat(vdp): resolved comments**

Because:

- Users need to retrieve pipeline runs efficiently, either for specific
pipelines or across all accessible pipelines.

This commit:

- Returns a paginated list of pipeline runs and components

---------

Co-authored-by: Till Knuesting <[email protected]>
Co-authored-by: droplet-bot <[email protected]>
heiruwu pushed a commit that referenced this pull request Aug 27, 2024
- **feat(vdp): Add Paginated List of logged Pipeline Runs Endpoint
Because:**
- **chore: auto-gen by protobufs**
- **feat(vdp): resolved comments**

Because:

- Users need to retrieve pipeline runs efficiently, either for specific
pipelines or across all accessible pipelines.

This commit:

- Returns a paginated list of pipeline runs and components

---------

Co-authored-by: Till Knuesting <[email protected]>
Co-authored-by: droplet-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

5 participants