feat(vdp): Add Paginated List of logged Pipeline Runs Endpoint #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - Users need to retrieve pipeline runs efficiently, either for specific pipelines or across all accessible pipelines. This commit: - Returns a paginated list of pipeline runs. - Supports querying for specific pipelines or all accessible pipelines. - Adds a gRPC method `ListPipelineRuns` with corresponding request and response types. - Exposes the endpoint via HTTP GET at `/v1beta/pipeline-runs`. - Tags the endpoint with "PipelineRun" for better API documentation.
triggered by commit: 28f5970
|
@jvallesm could you also check this PR? |
jvallesm
reviewed
Aug 8, 2024
| rpc ListPipelineRuns(ListPipelineRunsRequest) returns (ListPipelineRunsResponse) { | ||
| option (google.api.http) = { | ||
| get: "/v1beta/{namespace=users/*/namespaces/*}/pipeline-runs" | ||
| }; |
There was a problem hiding this comment.
Needs tag
Suggested change
| }; | |
| option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {tags: "Trigger"}; // TODO rename trigger as Run | |
| }; |
jvallesm
reviewed
Aug 8, 2024
|
Please rebase the branch on your own working branch to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: