Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anthropic): add Anthropic component #176

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

namwoam
Copy link
Collaborator

@namwoam namwoam commented Jun 25, 2024

Summary

  1. Added support for the Anthropic component with fields aligned to the current Instill model's "TASK_TEXT_GENERATION_CHAT" task.
  2. Added "GetBase64FileExtension" helper function and tests to the base component.

chuang8511
chuang8511 previously approved these changes Jun 25, 2024
Copy link
Member

@chuang8511 chuang8511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ai/anthropic/v0/main.go Outdated Show resolved Hide resolved
ai/anthropic/v0/main.go Outdated Show resolved Hide resolved
ai/anthropic/v0/main.go Outdated Show resolved Hide resolved
base/formats.go Outdated Show resolved Hide resolved
@donch1989
Copy link
Member

Hi @namwoam @chuang8511 ,
Thanks for your work. I've added some comments. Please take a look.

Copy link
Collaborator Author

@namwoam namwoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, changed the implementation to 2 layer for loop.

Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this is fixed, the PR can be merged.

ai/anthropic/v0/config/setup.json Outdated Show resolved Hide resolved
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donch1989 donch1989 changed the title feat: add Anthropic component feat(anthropic): add Anthropic component Jun 27, 2024
@donch1989 donch1989 merged commit 030881d into instill-ai:main Jun 27, 2024
6 checks passed
donch1989 pushed a commit that referenced this pull request Jul 2, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.21.0-beta](v0.20.2-beta...v0.21.0-beta)
(2024-07-02)


### Features

* add mail component
([#178](#178))
([04b19d0](04b19d0))
* add read task for gcs
([#155](#155))
([77fe2fc](77fe2fc))
* add read task in bigquery component
([#156](#156))
([4d2e7ec](4d2e7ec))
* **anthropic:** add Anthropic component
([#176](#176))
([030881d](030881d))
* **anthropic:** add UsageHandler functions in anthropic
([#186](#186))
([ebaa61f](ebaa61f))
* **compogen:** add extra section with --extraContents flag'
([#171](#171))
([391bb98](391bb98))
* **instill:** remove extra-params field
([#188](#188))
([b17ff73](b17ff73))
* **redis:** simplify the TLS configuration
([#194](#194))
([0a8baf7](0a8baf7))


### Bug Fixes

* **all:** fix typos
([#174](#174))
([cb3c2fb](cb3c2fb))
* **compogen:** wrong bracket direction in substitution
([#184](#184))
([dfe8306](dfe8306))
* expose input and output for anthropic for instill credit
([#190](#190))
([a36e876](a36e876))
* update doc
([#185](#185))
([6e6639a](6e6639a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
namwoam added a commit to namwoam/component that referenced this pull request Jul 8, 2024
Summary

1. Added support for the Anthropic component with fields aligned to the
current Instill model's "TASK_TEXT_GENERATION_CHAT" task.
2. Added "GetBase64FileExtension" helper function and tests to the base
component.

---------

Co-authored-by: Chang, Hui-Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👋 Done
4 participants