Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add read task for gcs #155

Merged
merged 7 commits into from
Jun 24, 2024
Merged

feat: add read task for gcs #155

merged 7 commits into from
Jun 24, 2024

Conversation

chuang8511
Copy link
Member

@chuang8511 chuang8511 commented Jun 6, 2024

Because

  • we do not have read objects and create bucket task for gcs

This commit

  • add read task for gcs
  • add create bucket task for gcs

Copy link

linear bot commented Jun 6, 2024

@chuang8511 chuang8511 marked this pull request as ready for review June 13, 2024 17:25
@donch1989
Copy link
Member

Hi @chuang8511
I guess you forgot to upload the definition and tasks.json.

@chuang8511
Copy link
Member Author

@donch1989
Sorry, do I miss to read something?
I think it is push. (please correct me if I misunderstand)
🙇

image

@donch1989
Copy link
Member

Hmm... that's weird, I didn't see those this morning...
BTW, can you help rebase it?

@chuang8511
Copy link
Member Author

I will notify you again after I rebase!
I may do it after 3~4 p.m. London time.
Sync to you first.

@chuang8511
Copy link
Member Author

same status like this branch
Will come back to do final e2e test after the frontend fixes the bug!

@chuang8511
Copy link
Member Author

Sync
I have done end to end test.

To make GCS more flexible, I add all params in the output of the component.
However, it damages UI a bit.

image

@donch1989 donch1989 merged commit 77fe2fc into main Jun 24, 2024
8 checks passed
@donch1989 donch1989 deleted the chunhao/ins-4803 branch June 24, 2024 02:58
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
Because

- we do not have read objects and create bucket task for gcs

This commit

- add read task for gcs
- add create bucket task for gcs
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
Because

- we do not have read objects and create bucket task for gcs

This commit

- add read task for gcs
- add create bucket task for gcs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👋 Done
4 participants