Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add read task for gcs #155

Merged
merged 7 commits into from
Jun 24, 2024
Merged

feat: add read task for gcs #155

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cd09b8a
feat: add the input and output structure for gcs read task
chuang8511 Jun 6, 2024
da98425
feat: read function implementation for gcs
chuang8511 Jun 6, 2024
a2e74cf
feat: add read objects task
chuang8511 Jun 13, 2024
829b6c1
feat: move bucket name to input
chuang8511 Jun 13, 2024
4d9d2b7
feat: add create bucket task
chuang8511 Jun 13, 2024
1d00842
fix: fix golintci error
chuang8511 Jun 13, 2024
dcb581c
chore: add comment and modify the document
chuang8511 Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix golintci error
  • Loading branch information
@chuang8511
chuang8511 committed Jun 17, 2024
commit 1d0084205fd5b52f6b8c428d13095f482b101caa
4 changes: 0 additions & 4 deletions data/googlecloudstorage/v0/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,6 @@ func NewClient(jsonKey string) (*storage.Client, error) {
return storage.NewClient(context.Background(), option.WithCredentialsJSON([]byte(jsonKey)))
}

func getBucketName(setup *structpb.Struct) string {
return setup.GetFields()["bucket-name"].GetStringValue()
}

func getJSONKey(setup *structpb.Struct) string {
return setup.GetFields()["json-key"].GetStringValue()
}
Expand Down