Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stack note complete content #4180

Merged
merged 49 commits into from
Jul 19, 2024
Merged
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
6640241
ignore note children for the time being
Schwehn42 May 8, 2024
0d9e380
try hook to set textarea
Schwehn42 May 8, 2024
e2fccb7
hook v1.1
Schwehn42 May 8, 2024
8e3b4af
Revert "hook v1.1"
Schwehn42 May 21, 2024
d47471b
Revert "try hook to set textarea"
Schwehn42 May 21, 2024
1aacb7f
use TextareaAutosize
Schwehn42 May 21, 2024
b5addd1
add colors to scrollbar mixin
Schwehn42 May 21, 2024
a5f6088
limit max note text height
Schwehn42 May 21, 2024
33b08b4
reorder note context text rules
Schwehn42 May 21, 2024
93e9dc3
put stack children next to parent
Schwehn42 May 22, 2024
a583ee7
workaround to get the scrollbar to be the same height as the parent note
Schwehn42 May 22, 2024
417906b
include scrollbar
Schwehn42 May 22, 2024
81790bd
Revert "workaround to get the scrollbar to be the same height as the …
Schwehn42 May 27, 2024
67fe393
trying some hardcoded values for the scolling
Schwehn42 May 27, 2024
d4694a2
max height + overflow fix?
Schwehn42 May 28, 2024
3ad122d
right container flexible height
Schwehn42 May 28, 2024
6aa8ee3
dynamically calc note max height
Schwehn42 May 28, 2024
14b4f17
mobile responsiveness
Schwehn42 May 29, 2024
b22f635
Merge branch 'refs/heads/main' into js/stack-note-complete-content
Schwehn42 May 29, 2024
3567bf9
breakpoint var
Schwehn42 May 30, 2024
43f4b7e
remove (hopefully) unnecessary css
Schwehn42 May 30, 2024
94e587a
Merge branch 'main' into js/stack-note-complete-content
Schwehn42 May 30, 2024
acde01a
scrollbar dark mode fix
Schwehn42 May 30, 2024
e44eaae
add scrollbar to stack view content
Schwehn42 May 30, 2024
73c358c
Merge remote-tracking branch 'origin/js/stack-note-complete-content' …
Schwehn42 May 30, 2024
582fb47
textareautosize: add missing attributes
Schwehn42 May 30, 2024
0092e03
Merge branch 'main' into js/stack-note-complete-content
Schwehn42 Jun 17, 2024
3045963
Merge branch 'refs/heads/main' into js/stack-note-complete-content
Schwehn42 Jul 9, 2024
18247f8
modernize scrollbar mixin
Schwehn42 Jul 10, 2024
a78e98b
fix: scrollbar border radius overflow
Schwehn42 Jul 10, 2024
89edbdd
omit unused import
Schwehn42 Jul 10, 2024
944d587
handle scroll class fix
Schwehn42 Jul 10, 2024
9ee2aa9
rename class name
Schwehn42 Jul 10, 2024
8a78c28
also subtract edited marker
Schwehn42 Jul 10, 2024
e27ddc2
Merge branch 'refs/heads/main' into js/stack-note-complete-content
Schwehn42 Jul 11, 2024
0601d2e
add inner scrollbar to stackview
Schwehn42 Jul 11, 2024
20d826a
try: mobile full height notes
Schwehn42 Jul 11, 2024
f3162d5
disabled padding fix
Schwehn42 Jul 11, 2024
2f22119
add comment
Schwehn42 Jul 11, 2024
559f01a
use intersectionobserver instead of scroll event
Schwehn42 Jul 11, 2024
56120cf
functional component
Schwehn42 Jul 11, 2024
f7fe2f2
Merge branch 'refs/heads/main' into js/stack-note-complete-content
Schwehn42 Jul 17, 2024
33688f9
use new colors for scrollbar
Schwehn42 Jul 17, 2024
85384b5
Merge branch 'refs/heads/main' into js/stack-note-complete-content
Schwehn42 Jul 19, 2024
533a37c
change grid to fit whole content
Schwehn42 Jul 19, 2024
36a1764
remove extended height class
Schwehn42 Jul 19, 2024
891cd5d
remove height
Schwehn42 Jul 19, 2024
26b6438
remove unused prop
Schwehn42 Jul 19, 2024
f27edf7
fix min line height
Schwehn42 Jul 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reorder note context text rules
  • Loading branch information
Schwehn42 committed May 21, 2024
commit 33b08b47362c1abe8d46aa8eaff8a80cd9ecffbb
Original file line number Diff line number Diff line change
Expand Up @@ -27,24 +27,28 @@ $note-content-text-max-height: 566px;
}

.note-dialog__note-content--text {
background: none;
margin: 0;
overflow-y: auto;
@include scrollbar(14px, 8px, var(--accent-color), var(--accent-color--dark));
width: 100%;
height: auto;
max-height: min(40vh, $note-content-text-max-height); // limit height
margin: 0;
padding: 0 4px;
overflow-y: auto;
resize: none;
word-wrap: break-word;

color: $color-black;
letter-spacing: $letter-spacing--medium;
font-size: $text--md;
line-height: 1.5rem;

background: none;
outline: none;

border: 2px dashed transparent;
border-radius: 5px;
transition: border-color 150ms ease-in-out;
outline: none;
resize: none;
word-wrap: break-word;
padding: 0 4px;
font-size: $text--md;
line-height: 1.5rem;

@include scrollbar(14px, 8px, var(--accent-color), var(--accent-color--dark));

&:not(:disabled) {
&:hover,
Expand Down