Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stack note complete content #4180

Merged
merged 49 commits into from
Jul 19, 2024
Merged

Conversation

Schwehn42
Copy link
Collaborator

@Schwehn42 Schwehn42 commented May 29, 2024

Description

Closes #2627
Reworks the stack view so that more content ist shown. If exceeding the height limit, the notes are scrollable. On Desktop, the parent will be displayed on the left hand side, while the child notes are on the right hand side. On Mobile, notes will remain on top of each other.

Changelog

  • reorder notes on desktop
  • make note content height dynamic
  • add media query for mobile
  • add a styled scrollbar

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

Bildschirmaufnahme.2024-05-29.um.17.07.45.mov

Bildschirmfoto 2024-05-29 um 16 26 34
Bildschirmfoto 2024-05-29 um 16 26 01

@Schwehn42 Schwehn42 self-assigned this May 29, 2024
@Schwehn42 Schwehn42 marked this pull request as ready for review May 30, 2024 11:46
@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label May 30, 2024
@inovex inovex deleted a comment from octomind-dev bot May 30, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

# Conflicts:
#	src/components/NoteDialogComponents/NoteDialogNoteComponents/NoteDialogNoteContent.scss
#	src/components/NoteDialogComponents/NoteDialogNoteWrapper.scss
#	src/constants/style.scss

This comment has been minimized.

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4180.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-0e73ee7

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-0e73ee7

Copy link

octomind-dev bot commented Jul 19, 2024

🐙 Octomind

Test Report: 13/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 0e73ee7

Copy link
Collaborator

@mateo-ivc mateo-ivc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label Jul 19, 2024
@Schwehn42 Schwehn42 added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit b0f40dd Jul 19, 2024
10 checks passed
@Schwehn42 Schwehn42 deleted the js/stack-note-complete-content branch July 19, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note in stack view should show more (... or complete?) content
2 participants