Mark GenericMemory as IndexLinear (JuliaLang#52082)

inkydragon · Nov 9, 2023 · 1b967b8 · 1b967b8
1 parent f99e6bf
commit 1b967b8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/base/genericmemory.jl b/base/genericmemory.jl
@@ -26,6 +26,8 @@ size(a::GenericMemory, d::Int) =
 size(a::GenericMemory, d::Integer) = size(a, convert(d, Int))
 size(a::GenericMemory) = (length(a),)
 
+IndexStyle(::Type{<:GenericMemory}) = IndexLinear()
+
 pointer(mem::GenericMemoryRef) = unsafe_convert(Ptr{Cvoid}, mem) # no bounds check, even for empty array
 
 _unsetindex!(A::Memory, i::Int) = (@_propagate_inbounds_meta; _unsetindex!(GenericMemoryRef(A, i)); A)

diff --git a/test/abstractarray.jl b/test/abstractarray.jl
@@ -1079,6 +1079,7 @@ end
 @testset "IndexStyle for various types" begin
  @test Base.IndexStyle(UpperTriangular) == IndexCartesian() # subtype of AbstractArray, not of Array
  @test Base.IndexStyle(Vector) == IndexLinear()
+ @test Base.IndexStyle(Memory) == IndexLinear()
  @test Base.IndexStyle(UnitRange) == IndexLinear()
  @test Base.IndexStyle(UpperTriangular(rand(3, 3)), [1; 2; 3]) == IndexCartesian()
  @test Base.IndexStyle(UpperTriangular(rand(3, 3)), rand(3, 3), [1; 2; 3]) == IndexCartesian()