Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark GenericMemory as IndexLinear #52082

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Mark GenericMemory as IndexLinear #52082

merged 1 commit into from
Nov 9, 2023

Conversation

N5N3
Copy link
Member

@N5N3 N5N3 commented Nov 8, 2023

No description provided.

@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Nov 8, 2023
@oscardssmith
Copy link
Member

seems correct. that said, does this change anything performance-wise?

@N5N3
Copy link
Member Author

N5N3 commented Nov 8, 2023

does this change anything performance-wise?

Not much I think, but without this SubArray of Memory would be a SlowSubArray. (Thus blocking type based dense check.)

@N5N3 N5N3 merged commit 1b967b8 into JuliaLang:master Nov 9, 2023
4 of 8 checks passed
@N5N3 N5N3 deleted the MemoryIndexStyle branch November 9, 2023 02:48
@giordano giordano removed the status:merge me PR is reviewed. Merge when all tests are passing label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@N5N3 @oscardssmith @vtjnash @giordano