Postgresql fix #224
Merged
Postgresql fix #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastvedt
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Hi @iegomez , this looks great 👍 We can just close the other PR and merge this? 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes work for #223.
@thomastvedt, feel free to check the additions and implement them in your fork if you wish; if so, I'll merge your PR instead.
Btw, I didn't add any tests because testing the life time of a connection as set by the
sqlxpackage is out of my control and probably quite pointless, specially after you've confirmed it as a fix to your issue. That said, when adding the option to the three DB backends using said package, I left the default behaviour to not set any max life time as to not break backwards compatibility: that is, if you need to set a max life time, you need to be explicit in your options file, there'll be no default time set by the plugin (other than thesqlxset one, if any).