Fix broken postgresql connection #223
Conversation
|
Hey, @thomastvedt! Just reaching out since we're getting close to the time frame you mentioned when Postgres starts becoming unresponsive. Ping me when you get some results from your tests and we'll merge it accordingly. |
Hi @iegomez , seems to be working fine, even with longer periods of inactivity (holidays) 👍. I'll delete the temporary build script / clean up, and you can merge :) |
| @@ -41,5 +42,7 @@ func OpenDatabase(dsn, engine string, tries int) (*sqlx.DB, error) { | |||
| return nil, fmt.Errorf("couldn't ping database %s: %s", engine, err) | |||
| } | |||
|
|
|||
| db.SetConnMaxLifetime(time.Minute) | |||
There was a problem hiding this comment.
Maybe we should make this an option so users may tune it. What do you think?
There was a problem hiding this comment.
Hey, that could be a good idea? Unfortunately I'm not a Go expert, and I'm not sure how to implement that :) Do you want to have a look at it?
There was a problem hiding this comment.
@thomastvedt sorry, I was on vacation and just got back. Sure, I'll do so.
There was a problem hiding this comment.
Great, thanks 😃
There was a problem hiding this comment.
Terribly sorry for the delay, but here it is, @thomastvedt: #224
thomastvedt
changed the title
|
Closing this, replaced by #224 |
See issue #218
This PR adds max connection lifetime to postgresql db connection. Hopefully this will help with our issue where the auth plugin / mosquitto stops responding after a while (typically 30+ days..)
We're testing this version now in production, we'll test it for a while to verify that it helps on stability. => seems to be working
#218
https://stackoverflow.com/questions/50338338/intermittent-connection-reset-by-peer-sql-postgres
I also bumped
from: github.com/jmoiron/sqlx v1.2.0
to: github.com/jmoiron/sqlx v1.3.4