Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate supplementary Protocol Buffers (protobuf) parameters into the JS client to augment the extensibility and functionality of the data model within the designated oneof constructs, ensuring a more comprehensive representation and utilization of transaction related information. #181

Closed
wants to merge 5 commits into from

Conversation

dominious1
Copy link

@dominious1 dominious1 commented Nov 30, 2023

Incorporate additional Protocol Buffers (protobuf) parameters into the JS client, enhancing the extensibility and functionality of the data model within the specified 'oneof' constructs. This integration ensures a more comprehensive representation and utilization of transaction-related information, thereby expanding the capabilities and flexibility of the system.

Those changes are connected with: hyperledger/iroha#4003 - this is part of internship project:
https://wiki.hyperledger.org/pages/viewpage.action?pageId=80778614

Copy link
Member

@baziorek baziorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not Javascript specialist

@baziorek baziorek added the iroha1 label Dec 1, 2023
baziorek and others added 2 commits January 23, 2024 10:30
…ge communication, with corresponding handling capabilities in Iroha CLI.

Signed-off-by: dominious1 <[email protected]>
@baziorek
Copy link
Member

@dominious1 Because I copied Your changes to another PR: #185
I'm closing this one

@baziorek baziorek closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants