Introduce an optional title parameter to the AddAssetQuantity and SubtractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. #4003

dominious1 · 2023-10-17T22:14:01Z

Description

Enhance functionality in the C++ Iroha base core code by introducing an optional argument, "title," to the AddAssetQuantity and SubtractAssetQuantity commands within the commands.proto bufs. Ensure seamless integration and functionality of this optional parameter, and optimize associated Gtests to accommodate these modifications. Additionally, enhance the Python client, contained in a separate repository, to effectively handle these changes. This refinement contributes to a more robust and adaptable system, aligning with the evolving requirements of the codebase.

Link to Python client library which use protobuf GRPC shared code base:
https://github.com/hyperledger/iroha-python/

This is part of internship project:
https://wiki.hyperledger.org/display/INTERN/Iroha+1%3A+extend+queries+with+optional+arguments

Link to PR in iroha-python compatible with those changes:
hyperledger/iroha-python#157

PR which updates documentation:
#4032

baziorek · 2023-10-18T05:08:03Z

@dominious1 Please add some description. I know that it is connected with internship project, but others also should know. And also provide link to client library.

shared_model/schema/queries.proto

shared_model/schema/commands.proto

baziorek

remember about changing documentation
remember about adding changes to iroha-lib (file: iroha/iroha-lib/model/Tx.{h,c}pp), if You have problems with this ask @andprogrammer

irohad/model/commands/add_asset_quantity.hpp

shared_model/interfaces/commands/subtract_asset_quantity.hpp

Signed-off-by: dominious1 <[email protected]>

baziorek · 2024-01-09T11:49:16Z

@dominious1 Good news! I was able (hopefully) to fix dependencies with golang: #4173
just resolve conflicts, and we will try to run tests and check if everything works now:D.

Signed-off-by: dominious1 <[email protected]>

baziorek

LGTM

baziorek · 2024-01-10T15:18:59Z

To sum up changes:

There were suggestion from @Mingela : Introduce an optional title parameter to the AddAssetQuantity and SubtractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. #4003 (review) - it was corrected, but ...
There were problem with dependencies - fixed by me in: Trying to repair dependency which stopped working (protoc for golang) #4173
After "Update branch" - all tests pass, and it is still good for me (revied already)

baziorek · 2024-01-19T08:48:01Z

@6r1d I just receive message from @lebdron that he reviewed this. But he does not have permissions to approve changes anymore.

@lebdron Thanks a lot for the review!

EDIT: Sorry, by accident I used wrong nicks. It was revieved by @iceseer , not @lebdron. Sorry @lebdron for pinging You:D.

6r1d · 2024-01-19T08:58:08Z

It was also checked by @iceseer

baziorek · 2024-01-19T09:22:11Z

@6r1d I just receive message from @lebdron that he reviewed this. But he does not have permissions to approve changes anymore.

@lebdron Thanks a lot for the review!

Sorry, I was wrong, it was checked by @iceseer not @lebdron . Sorry, it is my faoult that I not always connect nicks with people. Sorry for wrong information from me. Thanks @6r1d for correcting me:)

…tractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. (hyperledger#4003) * Implement addition of new parameters to Iroha Core for enhanced message communication, with corresponding handling capabilities in Iroha CLI. * Improve GTests in reference to param title * Enhance test coverage in the JsonCommandTest class by addressing serialization and deserialization scenarios for various command types. This commit ensures comprehensive testing, including edge cases and unknown command types, to guarantee the robustness of the JsonCommandFactory's functionality. * Enhance test cases related to the SubtractAccountAsset functionality to improve reliability, readability, and maintainability. This commit refactors and strengthens the existing test suite, addressing scenarios such as permission checks, domain permission validity, asset presence, precision validation, and asset quantity sufficiency. These improvements contribute to a more robust testing environment for the SubtractAccountAsset functionality. Signed-off-by: dominious1 <[email protected]> --------- Signed-off-by: dominious1 <[email protected]> Signed-off-by: dominious1 <[email protected]> Co-authored-by: G. Bazior <[email protected]>

…tractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. (hyperledger#4003) * Implement addition of new parameters to Iroha Core for enhanced message communication, with corresponding handling capabilities in Iroha CLI. * Improve GTests in reference to param title * Enhance test coverage in the JsonCommandTest class by addressing serialization and deserialization scenarios for various command types. This commit ensures comprehensive testing, including edge cases and unknown command types, to guarantee the robustness of the JsonCommandFactory's functionality. * Enhance test cases related to the SubtractAccountAsset functionality to improve reliability, readability, and maintainability. This commit refactors and strengthens the existing test suite, addressing scenarios such as permission checks, domain permission validity, asset presence, precision validation, and asset quantity sufficiency. These improvements contribute to a more robust testing environment for the SubtractAccountAsset functionality. Signed-off-by: dominious1 <[email protected]> --------- Signed-off-by: dominious1 <[email protected]> Signed-off-by: dominious1 <[email protected]> Co-authored-by: G. Bazior <[email protected]> Signed-off-by: dominious1 <[email protected]>

dominious1 had a problem deploying to test-env October 17, 2023 22:14 — with GitHub Actions Failure

baziorek added 1.x api-changes Changes in the API for client libraries 1.5 labels Oct 18, 2023

baziorek reviewed Oct 18, 2023

View reviewed changes

shared_model/schema/queries.proto Outdated Show resolved Hide resolved

shared_model/schema/commands.proto Outdated Show resolved Hide resolved

shared_model/schema/commands.proto Outdated Show resolved Hide resolved

baziorek assigned dominious1 Oct 18, 2023

dominious1 had a problem deploying to test-env October 31, 2023 21:19 — with GitHub Actions Failure

dominious1 had a problem deploying to test-env October 31, 2023 22:21 — with GitHub Actions Failure

dominious1 had a problem deploying to test-env October 31, 2023 22:52 — with GitHub Actions Failure

baziorek requested changes Nov 1, 2023

View reviewed changes

irohad/model/commands/add_asset_quantity.hpp Outdated Show resolved Hide resolved

shared_model/interfaces/commands/subtract_asset_quantity.hpp Outdated Show resolved Hide resolved

dominious1 had a problem deploying to test-env November 2, 2023 02:22 — with GitHub Actions Failure

dominious1 had a problem deploying to test-env November 2, 2023 02:24 — with GitHub Actions Failure

dominious1 added 3 commits January 4, 2024 06:57

Improve tests

25be6c3

Signed-off-by: dominious1 <[email protected]>

Add more sophisticated validator

79963ba

Signed-off-by: dominious1 <[email protected]>

Modify protobufs getter get go in Dockerfile

6cfda33

Signed-off-by: dominious1 <[email protected]>

mversic force-pushed the paramtitle branch from a2bb0b4 to 6cfda33 Compare January 4, 2024 05:57

Update Dockerfile with go configuration

d6f15ed

Signed-off-by: dominious1 <[email protected]>

dominious1 had a problem deploying to test-env January 9, 2024 23:49 — with GitHub Actions Failure

Merge branch 'main' into paramtitle

b9828de

baziorek temporarily deployed to test-env January 10, 2024 04:42 — with GitHub Actions Inactive

baziorek approved these changes Jan 10, 2024

View reviewed changes

Mingela approved these changes Jan 12, 2024

View reviewed changes

baziorek merged commit cd31f16 into hyperledger:main Jan 19, 2024
25 checks passed

baziorek mentioned this pull request Jan 19, 2024

[Confluence Documentation] Update message AddAssetQuantity and SubtractAssetQuantity with extra optional parameter #4032

Merged

baziorek mentioned this pull request Feb 2, 2024

Fixing warning in command SubtractAssetQuantity, removing unnecessarily includes, small documentation change #4251

Merged

5 tasks

nxsaken added the iroha1 The legacy version of Iroha. label Apr 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce an optional title parameter to the AddAssetQuantity and SubtractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. #4003

Introduce an optional title parameter to the AddAssetQuantity and SubtractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. #4003

dominious1 commented Oct 17, 2023 •

edited

Loading

baziorek commented Oct 18, 2023

baziorek left a comment •

edited

Loading

baziorek commented Jan 9, 2024 •

edited

Loading

baziorek left a comment

baziorek commented Jan 10, 2024

baziorek commented Jan 19, 2024 •

edited

Loading

6r1d commented Jan 19, 2024

baziorek commented Jan 19, 2024

Introduce an optional title parameter to the AddAssetQuantity and SubtractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. #4003

Introduce an optional title parameter to the AddAssetQuantity and SubtractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. #4003

Conversation

dominious1 commented Oct 17, 2023 • edited Loading

Description

baziorek commented Oct 18, 2023

baziorek left a comment • edited Loading

Choose a reason for hiding this comment

baziorek commented Jan 9, 2024 • edited Loading

baziorek left a comment

Choose a reason for hiding this comment

baziorek commented Jan 10, 2024

baziorek commented Jan 19, 2024 • edited Loading

6r1d commented Jan 19, 2024

baziorek commented Jan 19, 2024

dominious1 commented Oct 17, 2023 •

edited

Loading

baziorek left a comment •

edited

Loading

baziorek commented Jan 9, 2024 •

edited

Loading

baziorek commented Jan 19, 2024 •

edited

Loading