adapters: if session
is user-supplied, do not overwrite session options with Client
/Adapter
options
#1021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #991
Breaking change
For more details see also:
Before this change:
session
, a session is created for you with values for theverify
,cert
, andproxies
settings that are set in the adapter, either explicitly or by defaultsession
:session
will always be overwritten with the adapter values, whether you specified them or notAfter this change:
session
, a session is created for you with values for theverify
,cert
, andproxies
settings that are set in the adapter, either explicitly or by defaultsession
:verify
,cert
, orproxies
properties in your customsession
, then that value will be kept and the adapter's value will be ignored, even if you set it on the adapter explicitlyThe only case where this should cause breakage of existing code is where all of the following are true: