Need for Speed screen blinking fixed #16230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, this is definitely wrong, especially unless you also undo masking out the VRAM mirrors everywhere else. -[Unknown] |
unknownbrackets
requested changes
Oct 15, 2022
Comment on lines
-359
to
-360
| if (Memory::IsVRAMAddress(start)) | ||
| start &= 0x041FFFFF; |
There was a problem hiding this comment.
How will this properly detect a block transfer between a VRAM mirror in RAM (i.e. 0x04600000 let's say) and RAM (i.e. 0x09000000)? We now correctly normalize framebuffers and depth buffers to always mask out the mirrors so they're not all over the place.
-[Unknown]
There was a problem hiding this comment.
I am sorry but I have no knowledge of that code.
Removal of this two lines fixed the mentioned issue for me.
|
I am closing this PR as I am not capable to finish it. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just a revert of code change causing screen blinking on some GPUs. The code was introduced in #16150.
After merging the PR, we can close #16175.
Affected game is NFS Pro street.