Remove some depricated code pointed in #2655; #2808
Conversation
mat1th
force-pushed
the
feature/remove-depricated-and-not-used-code
branch
from
0128652
to
7b810bc
Compare
| @@ -293,7 +293,7 @@ extension NotificationManager: UNUserNotificationCenterDelegate { | |||
| return | |||
| } | |||
|
|
|||
| var methods: UNNotificationPresentationOptions = [.alert, .badge, .sound] | |||
There was a problem hiding this comment.
alert is deprecated since iOS 14 see https://developer.apple.com/documentation/usernotifications/unnotificationpresentationoptions/alert
There was a problem hiding this comment.
Good point, I've added them.
| @@ -104,7 +104,7 @@ class IncomingURLHandler { | |||
| pipeline: pipeline?.identifier ?? "", | |||
| autoStartRecording: autoStartRecording | |||
| ) | |||
| case let .rejected(error): | |||
| case .rejected: | |||
There was a problem hiding this comment.
Error value was not used;
There was a problem hiding this comment.
Perhaps this instead:
Current.Log.error("Failed to obtain webview to open Assist In App: \(error.localizedDescription)")
|
Thank you! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2808 +/- ##
==========================================
+ Coverage 27.54% 28.40% +0.85%
==========================================
Files 311 360 +49
Lines 31699 24536 -7163
==========================================
- Hits 8733 6970 -1763
+ Misses 22966 17566 -5400 ☔ View full report in Codecov by Sentry. |
mat1th
force-pushed
the
feature/remove-depricated-and-not-used-code
branch
from
1afe1f4
to
3e49cca
Compare
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Thank you! |
Summary
In issue #2655 there is some code referenced that is not needed anymore. So I've removed it.
Screenshots
The app still launches on a iPhone simulator. Could not test the macOS target.
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes