Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated iOS 12 things #2655

Closed
michalsrutek opened this issue Mar 19, 2024 · 2 comments
Closed

Remove deprecated iOS 12 things #2655

michalsrutek opened this issue Mar 19, 2024 · 2 comments
Assignees
@bgoncal
Labels
dev ios

Comments

@michalsrutek
Copy link
Contributor

There are still things in the project annotated with @available(iOS, deprecated: 13.0). Namely

  • UIWindow's convenience init(haForiOS12: ())
  • StateRestorationKey
  • viewController(withRestorationIdentifierPath identifierComponents: [String])
  • SceneManagerPreSceneCompatibility

which could be removed, as the min iOS version is now 15.
@bgoncal bgoncal added dev and removed bug labels Mar 20, 2024
@bgoncal
Copy link
Member

bgoncal commented Apr 17, 2024

Hey @michalsrutek, I see you started contributing to the project, could you help out with this one? No pressure though

@bgoncal bgoncal self-assigned this Apr 17, 2024
@mat1th mat1th mentioned this issue Jun 3, 2024
Merged
bgoncal added a commit that referenced this issue Jun 10, 2024
@mat1th @bgoncal
Remove some depricated code pointed in #2655; (#2808)
d5fe2ee 
## Summary
In issue #2655 there is some code referenced that is not needed anymore.
So I've removed it.

## Screenshots
The app still launches on a iPhone simulator. Could not test the macOS
target.

## Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#

## Any other notes
-

---------

Co-authored-by: Bruno Pantaleão Gonçalves <[email protected]>
@bgoncal
Copy link
Member

bgoncal commented Jun 10, 2024

Thanks @mat1th 🥳

@bgoncal bgoncal closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgoncal bgoncal

Labels
dev ios
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bgoncal @michalsrutek