fix(archive): Fix bug in migrating cluster name. Fixes argoproj#2272 (a…

…rgoproj#2279)
highb · Feb 20, 2020 · c33f6cd · c33f6cd
1 parent fb0acbb
commit c33f6cd
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/persist/sqldb/migrate.go b/persist/sqldb/migrate.go
@@ -130,7 +130,7 @@ func (m migrate) Exec(ctx context.Context) error {
  ansiSQLChange(`alter table argo_archived_workflows alter column finishedat set not null`),
  ),
  ansiSQLChange(`alter table argo_archived_workflows add clustername varchar(64)`), // DNS entry can only be max 63 bytes
- ansiSQLChange(`update argo_archived_workflows set clustername = ` + m.clusterName + ` where clustername is null`),
+ ansiSQLChange(`update argo_archived_workflows set clustername = '` + m.clusterName + `' where clustername is null`),
  ternary(dbType == MySQL,
  ansiSQLChange(`alter table argo_archived_workflows modify column clustername varchar(64) not null`),
  ansiSQLChange(`alter table argo_archived_workflows alter column clustername set not null`),
@@ -157,7 +157,7 @@ func (m migrate) Exec(ctx context.Context) error {
  ansiSQLChange(`alter table `+m.tableName+` alter column namespace set not null`),
  ),
  ansiSQLChange(`alter table ` + m.tableName + ` add column clustername varchar(64)`), // DNS cannot be longer than 64 bytes
- ansiSQLChange(`update ` + m.tableName + ` set clustername = ` + m.clusterName + ` where clustername is null`),
+ ansiSQLChange(`update ` + m.tableName + ` set clustername = '` + m.clusterName + `' where clustername is null`),
  ternary(dbType == MySQL,
  ansiSQLChange(`alter table `+m.tableName+` modify column clustername varchar(64) not null`),
  ansiSQLChange(`alter table `+m.tableName+` alter column clustername set not null`),