Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(persistence): Fix bug in migrating cluster name. Fixes #2278 #2279

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 20, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • [ x] Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Fixes #2278.
Can be merged as soon as approved. Needs back-porting.

@alexec alexec changed the title fix(archive): Fix bug in migrating cluster name. Fixes #2278 fix(persistence): Fix bug in migrating cluster name. Fixes #2278 Feb 20, 2020
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@fb0acbb). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2279   +/-   ##
=========================================
  Coverage          ?   11.38%           
=========================================
  Files             ?       71           
  Lines             ?    27933           
  Branches          ?        0           
=========================================
  Hits              ?     3180           
  Misses            ?    24349           
  Partials          ?      404
Impacted Files Coverage Δ
persist/sqldb/migrate.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb0acbb...79c0894. Read the comment docs.

@alexec alexec merged commit c33f6cd into argoproj:master Feb 20, 2020
@alexec alexec deleted the fix-2272 branch February 20, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clusterName is not properly quoted in SQL migrations
2 participants