Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/gocd] Quote ingress host #20477

Merged
merged 4 commits into from
Feb 1, 2020
Merged

[stable/gocd] Quote ingress host #20477

merged 4 commits into from
Feb 1, 2020

Conversation

austinorth
Copy link
Contributor

When using a wildcard DNS name for host, such as *.example.com, Helm
fails with a yaml parsing error.

Signed-off-by: Austin Orth [email protected]

What this PR does / why we need it:

Added quote function to allow use of wildcard DNS names in the ingress template. Without this PR, Helm will error when trying to set up the ingress when users try a wildcard DNS name.

Which issue this PR fixes

When setting hosts in values file to ["*.example.com"]

$ helm install gocd ./ -f ~/gocd/values.aws.yaml
coalesce.go:199: warning: destination for annotations is a table. Ignoring non-table value <nil>
Error: YAML parse error on gocd/templates/ingress.yaml: error converting YAML to JSON: yaml: line 16: did not find expected alphabetic or numeric character

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

cc: @arvindsv @GaneshSPatil @varshavaradarajan

Austin Orth added 2 commits January 31, 2020 11:32
[stable/gocd] Quote ingress host
e2f27a9 
When using a wildcard DNS name for host, such as *.example.com, Helm
fails with a yaml parsing error. Added quote function to allow use of
wildcard.

Signed-off-by: Austin Orth <[email protected]>
[stable/gocd] Bump Chart version
3d28055 
Signed-off-by: Austin Orth <[email protected]>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 31, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @austinorth. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

varshavaradarajan
varshavaradarajan approved these changes Jan 31, 2020
View reviewed changes
Copy link
Collaborator

@varshavaradarajan varshavaradarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @austinorth! Do you mind changing the api version of ingress to networking.k8s.io/v1beta1? Just want to avoid an additional release just for that. I had tried doing it before - #15377 (comment)

[stable/gocd] Ingress api version change
b856007 
Changed version of api for ingress to networking.k8s.io/v1beta1.

Signed-off-by: Austin Orth <[email protected]>
@varshavaradarajan
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2020
@varshavaradarajan
Copy link
Collaborator

@austinorth - Can you please update the changelog?

@austinorth
Copy link
Contributor Author

austinorth commented Jan 31, 2020 •
edited
Loading

@varshavaradarajan sure! should I include the chart version bump commit, or just b856007 and e2f27a9 ?

@varshavaradarajan
Copy link
Collaborator

just b856007 and e2f27a9 should be fine

[stable/gocd] Updated changelog
06167a4 
Updated the changelog with relevant commits for this patch version.

Signed-off-by: Austin Orth <[email protected]>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2020
@varshavaradarajan
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: austinorth, varshavaradarajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit f026a77 into helm:master Feb 1, 2020
sc2borges pushed a commit to sc2borges/charts that referenced this pull request Feb 3, 2020
[stable/gocd] Quote ingress host (helm#20477)
98aae02 
* [stable/gocd] Quote ingress host

When using a wildcard DNS name for host, such as *.example.com, Helm
fails with a yaml parsing error. Added quote function to allow use of
wildcard.

Signed-off-by: Austin Orth <[email protected]>

* [stable/gocd] Bump Chart version

Signed-off-by: Austin Orth <[email protected]>

* [stable/gocd] Ingress api version change

Changed version of api for ingress to networking.k8s.io/v1beta1.

Signed-off-by: Austin Orth <[email protected]>

* [stable/gocd] Updated changelog

Updated the changelog with relevant commits for this patch version.

Signed-off-by: Austin Orth <[email protected]>

Signed-off-by: Sergio Borges <[email protected]>
sc2borges pushed a commit to sc2borges/charts that referenced this pull request Feb 4, 2020
[stable/gocd] Quote ingress host (helm#20477)
a46faa3 
* [stable/gocd] Quote ingress host

When using a wildcard DNS name for host, such as *.example.com, Helm
fails with a yaml parsing error. Added quote function to allow use of
wildcard.

Signed-off-by: Austin Orth <[email protected]>

* [stable/gocd] Bump Chart version

Signed-off-by: Austin Orth <[email protected]>

* [stable/gocd] Ingress api version change

Changed version of api for ingress to networking.k8s.io/v1beta1.

Signed-off-by: Austin Orth <[email protected]>

* [stable/gocd] Updated changelog

Updated the changelog with relevant commits for this patch version.

Signed-off-by: Austin Orth <[email protected]>
Signed-off-by: Sergio Borges <[email protected]>
MarcusSorealheis added a commit to MarcusSorealheis/charts that referenced this pull request Feb 4, 2020
@MarcusSorealheis
Merge remote-tracking branch 'upstream/master' into add_superset_main…
51c5fba 
…tainer

* upstream/master: (309 commits)
  [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523)
  [stable/prometheus-redis-exporter] Update image for exporter (helm#19317)
  update alantis version (helm#20507)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517)
  [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409)
  Allow DNS egress to resolve hostnames (helm#20437)
  [stable/rabbitmq] Add PrometheusRule. (helm#20478)
  [stable/drupal] Release 6.2.4 updating components versions (helm#20491)
  [stable/metabase] interpolate liveness and readiness probes (helm#20475)
  [stable/grafana] Fix a typo in the Grafana chart notes (helm#20490)
  [stable/gocd] Quote ingress host (helm#20477)
  [stable/metabase] allow setting jetty options (helm#20456)
  [stable/pgadmin] upgrade to 4.17 and more (helm#20211)
  [stable/prometheus-operator] add apiserverConfig (helm#20453)
  [stable/graylog] Fix helm#20306, add `helm2Compatibility` flag to `values.yaml` that preserves specific labels installed by helm2 for backward compatibility. (helm#20464)
  Add annotation support to pushgateway service (helm#20351)
  Upgrade nfs-provisioner to v2.3.0 (helm#20468)
  [stable/sysdig] Upgrade to latest Sysdig Image (9.5.0) (helm#20471)
  [stable/odoo] Update PostgreSQL dependency to latest major (helm#20467)
  [stable/redis] Add PrometheusRule. (helm#20388)
  ...
alexppg pushed a commit to alexppg/charts that referenced this pull request Feb 4, 2020
@alexppg
[stable/gocd] Quote ingress host (helm#20477)
d5413b9 
* [stable/gocd] Quote ingress host

When using a wildcard DNS name for host, such as *.example.com, Helm
fails with a yaml parsing error. Added quote function to allow use of
wildcard.

Signed-off-by: Austin Orth <[email protected]>

* [stable/gocd] Bump Chart version

Signed-off-by: Austin Orth <[email protected]>

* [stable/gocd] Ingress api version change

Changed version of api for ingress to networking.k8s.io/v1beta1.

Signed-off-by: Austin Orth <[email protected]>

* [stable/gocd] Updated changelog

Updated the changelog with relevant commits for this patch version.

Signed-off-by: Austin Orth <[email protected]>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
[stable/gocd] Quote ingress host (helm#20477)
3c52730 
* [stable/gocd] Quote ingress host

When using a wildcard DNS name for host, such as *.example.com, Helm
fails with a yaml parsing error. Added quote function to allow use of
wildcard.

Signed-off-by: Austin Orth <[email protected]>

* [stable/gocd] Bump Chart version

Signed-off-by: Austin Orth <[email protected]>

* [stable/gocd] Ingress api version change

Changed version of api for ingress to networking.k8s.io/v1beta1.

Signed-off-by: Austin Orth <[email protected]>

* [stable/gocd] Updated changelog

Updated the changelog with relevant commits for this patch version.

Signed-off-by: Austin Orth <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@varshavaradarajan varshavaradarajan Awaiting requested review from varshavaradarajan

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@austinorth @k8s-ci-robot @varshavaradarajan @helm-bot