Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/pgadmin] upgrade to 4.17 and more #20211

Merged
merged 3 commits into from
Jan 31, 2020
Merged

[stable/pgadmin] upgrade to 4.17 and more #20211

merged 3 commits into from
Jan 31, 2020

Conversation

rowanruseler
Copy link
Contributor

4.17:
with 4.16 and up USER: pgadmin got added to the Dockerfile, this
caused an ACL issue. securityContext and initContainers is added to
resolve this issue.

other:

  • fixed dynamic PV provisioning
  • livenessProbe
  • readinessProbe
  • added more comments in values.yaml
  • updated README.md with new configuration items
  • chart bump version

Signed-off-by: Rowan Ruseler [email protected]

@rowanruseler
[stable/pgadmin] upgrade to 4.17 and more
e54c33f 
4.17:
  with 4.16 and up `USER: pgadmin` got added to the Dockerfile, this
  caused an ACL issue. securityContext and initContainers is added to
  resolve this issue.

other:
  - fixed dynamic PV provisioning
  - livenessProbe
  - readinessProbe
  - added more comments in values.yaml
  - updated README.md with new configuration items
  - chart bump version

Signed-off-by: Rowan Ruseler <[email protected]>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jan 17, 2020
@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @rowanruseler. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 17, 2020
@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2020
davidkarlsen
davidkarlsen reviewed Jan 20, 2020
View reviewed changes
stable/pgadmin/templates/deployment.yaml
{{- end }}
{{- with .Values.tolerations }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more of a personal taste - but I favour using with as it is easier to read and keep consistent due to no duplication.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like me to adjust this? Personally I found this statement more clear. But I don't mind adjusting it back.

davidkarlsen
davidkarlsen reviewed Jan 20, 2020
View reviewed changes
stable/pgadmin/templates/pvc.yaml
@@ -1,19 +1,26 @@
{{- if and .Values.persistence.enabled (not .Values.persistence.existingClaim) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md for info on persistence

@rowanruseler
[stable/pgadmin] adjusted storageclass name
5c8ad58 
made a mistake with naming the variable different then what is shown in
the values.yml example

Signed-off-by: Rowan Ruseler <[email protected]>
@rowanruseler
[stable/pgadmin]
7ec2669 
resolved sessions bug by letting the probes go to the correct path

Signed-off-by: Rowan Ruseler <[email protected]>
prydonius
prydonius approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prydonius, rowanruseler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit e71080f into helm:master Jan 31, 2020
sc2borges pushed a commit to sc2borges/charts that referenced this pull request Feb 3, 2020
@rowanruseler
[stable/pgadmin] upgrade to 4.17 and more (helm#20211)
6625dd9 
* [stable/pgadmin] upgrade to 4.17 and more

4.17:
  with 4.16 and up `USER: pgadmin` got added to the Dockerfile, this
  caused an ACL issue. securityContext and initContainers is added to
  resolve this issue.

other:
  - fixed dynamic PV provisioning
  - livenessProbe
  - readinessProbe
  - added more comments in values.yaml
  - updated README.md with new configuration items
  - chart bump version

Signed-off-by: Rowan Ruseler <[email protected]>

* [stable/pgadmin] adjusted storageclass name

made a mistake with naming the variable different then what is shown in
the values.yml example

Signed-off-by: Rowan Ruseler <[email protected]>

* [stable/pgadmin]

resolved sessions bug by letting the probes go to the correct path

Signed-off-by: Rowan Ruseler <[email protected]>

Signed-off-by: Sergio Borges <[email protected]>
sc2borges pushed a commit to sc2borges/charts that referenced this pull request Feb 4, 2020
@rowanruseler
[stable/pgadmin] upgrade to 4.17 and more (helm#20211)
d22b584 
* [stable/pgadmin] upgrade to 4.17 and more

4.17:
  with 4.16 and up `USER: pgadmin` got added to the Dockerfile, this
  caused an ACL issue. securityContext and initContainers is added to
  resolve this issue.

other:
  - fixed dynamic PV provisioning
  - livenessProbe
  - readinessProbe
  - added more comments in values.yaml
  - updated README.md with new configuration items
  - chart bump version

Signed-off-by: Rowan Ruseler <[email protected]>

* [stable/pgadmin] adjusted storageclass name

made a mistake with naming the variable different then what is shown in
the values.yml example

Signed-off-by: Rowan Ruseler <[email protected]>

* [stable/pgadmin]

resolved sessions bug by letting the probes go to the correct path

Signed-off-by: Rowan Ruseler <[email protected]>
Signed-off-by: Sergio Borges <[email protected]>
MarcusSorealheis added a commit to MarcusSorealheis/charts that referenced this pull request Feb 4, 2020
@MarcusSorealheis
Merge remote-tracking branch 'upstream/master' into add_superset_main…
51c5fba 
…tainer

* upstream/master: (309 commits)
  [stable/moodle] Set MOODLE_SKIP_INSTALL environment variable via values.yaml config. (helm#20523)
  [stable/prometheus-redis-exporter] Update image for exporter (helm#19317)
  update alantis version (helm#20507)
  [stable/spring-cloud-data-flow] Update to new SCDF version 2.4.0 (helm#20517)
  [stable/prometheus-blackbox-exporter] add "allowIcmp" setting (helm#20409)
  Allow DNS egress to resolve hostnames (helm#20437)
  [stable/rabbitmq] Add PrometheusRule. (helm#20478)
  [stable/drupal] Release 6.2.4 updating components versions (helm#20491)
  [stable/metabase] interpolate liveness and readiness probes (helm#20475)
  [stable/grafana] Fix a typo in the Grafana chart notes (helm#20490)
  [stable/gocd] Quote ingress host (helm#20477)
  [stable/metabase] allow setting jetty options (helm#20456)
  [stable/pgadmin] upgrade to 4.17 and more (helm#20211)
  [stable/prometheus-operator] add apiserverConfig (helm#20453)
  [stable/graylog] Fix helm#20306, add `helm2Compatibility` flag to `values.yaml` that preserves specific labels installed by helm2 for backward compatibility. (helm#20464)
  Add annotation support to pushgateway service (helm#20351)
  Upgrade nfs-provisioner to v2.3.0 (helm#20468)
  [stable/sysdig] Upgrade to latest Sysdig Image (9.5.0) (helm#20471)
  [stable/odoo] Update PostgreSQL dependency to latest major (helm#20467)
  [stable/redis] Add PrometheusRule. (helm#20388)
  ...
@rowanruseler rowanruseler deleted the rr/pgadmin-4.17 branch February 5, 2020 08:19
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@rowanruseler
[stable/pgadmin] upgrade to 4.17 and more (helm#20211)
79b4ba2 
* [stable/pgadmin] upgrade to 4.17 and more

4.17:
  with 4.16 and up `USER: pgadmin` got added to the Dockerfile, this
  caused an ACL issue. securityContext and initContainers is added to
  resolve this issue.

other:
  - fixed dynamic PV provisioning
  - livenessProbe
  - readinessProbe
  - added more comments in values.yaml
  - updated README.md with new configuration items
  - chart bump version

Signed-off-by: Rowan Ruseler <[email protected]>

* [stable/pgadmin] adjusted storageclass name

made a mistake with naming the variable different then what is shown in
the values.yml example

Signed-off-by: Rowan Ruseler <[email protected]>

* [stable/pgadmin]

resolved sessions bug by letting the probes go to the correct path

Signed-off-by: Rowan Ruseler <[email protected]>
Signed-off-by: Miguel Mingorance <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidkarlsen davidkarlsen davidkarlsen left review comments

@prydonius prydonius prydonius approved these changes

@mattfarina mattfarina Awaiting requested review from mattfarina

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rowanruseler @k8s-ci-robot @zanhsieh @davidkarlsen @prydonius @helm-bot