Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there has tip: https://github.com/neovim-puppet/tree-sitter-puppet/tree/main/test/highlight
@jficz The file type here will conflict with pascal, can be overridden by custom languages.toml reconfiguration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually argue that it is Pascal (or, specifically, FreePascal's need to be different) which is in conflict with Puppet here. Historically and practically,
.pas
is the recognized Pascal extension..pp
is just a vendor-specific variant which doesn't really have a rational reason to exist in the first place and therefore it should be the other way around, that is..pp
for (Free)Pascal files should be overridden by custom language.toml if needed.Some high-profile Pascal IDEs and variants don't even recognize
.pp
as Pascal files as far as I know while for Puppet,.pp
is universally recognized.