-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puppet Support #6412
Open
gautamprikshit1
wants to merge
2
commits into
helix-editor:master
Choose a base branch
from
gautamprikshit1:puppet
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Puppet Support #6412
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next
Next commit
Added puppet support
- Loading branch information
commit f52eb496789b58a4db9f7c4e0b632a95e06749b7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
(function) @function | ||
(variable) @variable | ||
[ | ||
(identifier) | ||
] @identifier | ||
|
||
[ | ||
"class" | ||
"define" | ||
"plan" | ||
"node" | ||
"type" | ||
] @keyword | ||
|
||
[ | ||
"contain" | ||
"include" | ||
"inherits" | ||
"require" | ||
] @include | ||
|
||
[ | ||
"case" | ||
"else" | ||
"elsif" | ||
"if" | ||
"unless" | ||
] @conditional | ||
|
||
(string) @string | ||
(regex) @regex | ||
(integer) @number | ||
(float) @float | ||
(regex) @string.regex | ||
(comment) @comment | ||
[(true) (false)] @boolean | ||
|
||
(unprotected_string) @text | ||
|
||
[ | ||
(chaining_arrow) | ||
(operator) | ||
] @operator | ||
|
||
|
||
(interpolation | ||
"${" @punctuation.special | ||
"}" @punctuation.special) @none | ||
|
||
Comment on lines
+1
to
+49
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
[ | ||
"(" | ||
")" | ||
"[" | ||
"]" | ||
"{" | ||
"}" | ||
]@punctuation.bracket | ||
|
||
[ | ||
"," | ||
":" | ||
"::" | ||
] @punctuation.delimiter | ||
|
||
[(type) (type_identifier)] @type | ||
|
||
(escape_sequence) @escape | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there has tip: https://github.com/neovim-puppet/tree-sitter-puppet/tree/main/test/highlight
@jficz The file type here will conflict with pascal, can be overridden by custom languages.toml reconfiguration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually argue that it is Pascal (or, specifically, FreePascal's need to be different) which is in conflict with Puppet here. Historically and practically,
.pas
is the recognized Pascal extension..pp
is just a vendor-specific variant which doesn't really have a rational reason to exist in the first place and therefore it should be the other way around, that is..pp
for (Free)Pascal files should be overridden by custom language.toml if needed.Some high-profile Pascal IDEs and variants don't even recognize
.pp
as Pascal files as far as I know while for Puppet,.pp
is universally recognized.