-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large Gruvbox refactoring #10773
Large Gruvbox refactoring #10773
Conversation
Nice ! I use gruvbox and that is an improvement indeed. |
A few things that left me puzzled about this:
Now for some personal opinions:
|
I think orange is more suitable for warnings and yellow for infos, so I will change colors there. |
that would be the case but red and orange are quite hard to differentiate in gruvbox (especially with the light theme) |
I brought the purple1 back) |
The main question for me in this case is will it be ok if I set yellow for warnings and aqua for both hints and infos?) |
I think the current diagnostic colors are fine:
Now the real question becomes how do we handle diagnostic information which is not in the original theme, namely Unnecessary and Deprecated:
|
Made so, but aqua for info and blue for hints as it was before :)
I commented this line for future changes.
Probably we should, by the way, but I used gruvbox theme only with NeoVim. Not Vim. So for me it's easier to compare this theme with NeoVim's implementation. |
@Locorock, I also set diff.delta color to yellow as for the color of warnings :) |
92ddffa
to
6caf005
Compare
9c1e3fd
to
6caf005
Compare
38fbf9e
to
9069411
Compare
* gruvbox refactoring * removed unnecessary lines * set purple1 for operators * changed diagnostics colors * removed some unnecessary lines * set diff.delta color to yellow * removed some tag colors
* gruvbox refactoring * removed unnecessary lines * set purple1 for operators * changed diagnostics colors * removed some unnecessary lines * set diff.delta color to yellow * removed some tag colors
Not so long ago I completely switched from Dracula to Gruvbox and I decided to make it more comfortable according to NVim Gruvbox colors.
I changed operator color with some other colors and disabled some bold fonts:
![image](https://private-user-images.githubusercontent.com/78883260/331113541-f29df094-216f-4175-b3e0-cfa6cb1d1b57.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5ODI5MjksIm5iZiI6MTcyMzk4MjYyOSwicGF0aCI6Ii83ODg4MzI2MC8zMzExMTM1NDEtZjI5ZGYwOTQtMjE2Zi00MTc1LWIzZTAtY2ZhNmNiMWQxYjU3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDEyMDM0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMwNDU3OTExYWI1MTE4ODYwMzI0MjJkZGI0OTZkZmZmMzIxM2QwNzlhY2I5ODk1ZGE4YTVkMDE3N2VkOTkzNGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0._9pX_tLiSHx9acbyrv-_1qTuRHmRZSU4YK4nGfJ1ADw)
I also improved cursor/cursorline colors and made cursor color the same as the mode color. You can notice that primary cursorline is a bit lighter:
Normal mode with multicursor:
![image](https://private-user-images.githubusercontent.com/78883260/331126346-4ad3cc57-994c-4c61-a931-e65656820a06.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5ODI5MjksIm5iZiI6MTcyMzk4MjYyOSwicGF0aCI6Ii83ODg4MzI2MC8zMzExMjYzNDYtNGFkM2NjNTctOTk0Yy00YzYxLWE5MzEtZTY1NjU2ODIwYTA2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDEyMDM0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThjM2ZmZTM4ZmRhNTkwYzcyZDFjNDQ1ZWM5Zjg3ZGI2ZWJkNTQwYzdiZjJhMTRmYjU1YzE4ZGI2YjUyNWQ0NjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.VpwN05o9fXSd_OJ2CpbP1xAWZQwoc-tnHgqHRIeN9Nk)
Selection mode with multicursor:
![image](https://private-user-images.githubusercontent.com/78883260/331115684-145cb40a-ab6f-4280-bc7e-bdd857b65116.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5ODI5MjksIm5iZiI6MTcyMzk4MjYyOSwicGF0aCI6Ii83ODg4MzI2MC8zMzExMTU2ODQtMTQ1Y2I0MGEtYWI2Zi00MjgwLWJjN2UtYmRkODU3YjY1MTE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDEyMDM0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE3MWM4NmQ1MTliNmE4OWI5ZjY1ZjEzY2EwZTNiYzkwODM5Y2FjYTM3MzBlMTUyZDE3NjFhZDA3MDc3OTVmNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.7kWDQuPWhUGC_1u8bCvppiVltgha5Em-DSuH5csN9Pg)
Insert mode with multicursor:
![image](https://private-user-images.githubusercontent.com/78883260/331125535-5a92d2b0-3076-427f-86b8-cc685d0f812f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5ODI5MjksIm5iZiI6MTcyMzk4MjYyOSwicGF0aCI6Ii83ODg4MzI2MC8zMzExMjU1MzUtNWE5MmQyYjAtMzA3Ni00MjdmLTg2YjgtY2M2ODVkMGY4MTJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDEyMDM0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAxZTNhODMyYTViMzFhYjVjOGFiMjY0NTcyMTk2ZDY4OWQyZDkzMWMyOTFmYzdiYTQyMWZkM2I3NzE1ODliMWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YoPJ0NvRF8cNyBphty4ijmNoKlxCYD7Xf0V_JKvMix4)
Now, diagnostics:
I decided to choose diagnostics colours according to their severity level:
Hint - aqua
![image](https://private-user-images.githubusercontent.com/78883260/331146058-31b8b98e-e815-422a-b22a-5eb7cc8b4538.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5ODI5MjksIm5iZiI6MTcyMzk4MjYyOSwicGF0aCI6Ii83ODg4MzI2MC8zMzExNDYwNTgtMzFiOGI5OGUtZTgxNS00MjJhLWIyMmEtNWViN2NjOGI0NTM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDEyMDM0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk2YWU5OWI1OWQ2NzRmZDcyNDViMGFhYzgxZDlmMDkyYjk1YWVjYWRmZmI4MWI4NjBiZWJjY2ZhN2FhMWJhZjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.AUoRQXSRaeFVBxoEPtd4q4yE08S32TiA8HWW9LaDfXw)
Info - yellow
Sorry for no image but I didn't find any examples :)
Warning - orange and Error - red
![image](https://private-user-images.githubusercontent.com/78883260/331144161-c9d2a04b-0faf-4ba0-ae18-f48ce2af7884.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5ODI5MjksIm5iZiI6MTcyMzk4MjYyOSwicGF0aCI6Ii83ODg4MzI2MC8zMzExNDQxNjEtYzlkMmEwNGItMGZhZi00YmEwLWFlMTgtZjQ4Y2UyYWY3ODg0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE4VDEyMDM0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ1MjY5ZjZkYmViMjY0NTlmMTg2OWI1NmM4ZWM4OWU1ZDM3YjlkMmI2OTI5MGJiYjQzNTMxNzI1YzgwN2U1YTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.XMKNylCMVpvyrjGuR9_E6gJTvqRZilcxjZWoMlyrkB0)
I hope you will like theese changes and I am open to your improvements :)