refactor(themes): gruvbox warnings to yellow1
#10506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Apr 19, 2024
|
@RoloEdits, I'm working on this theme now) |
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current choice for
orange1came from theCoCsetting in the gruvbox repo, however, both theALEandSyntasticsettings useyellow. Going by majority rule, and a stated improvement by someone who uses a version of the theme, this changes the color toyellow1fromorange1.In hopes for as small a footprint as possible, and to propagate changes to maintain consistency between
gruvboxvariations, I changed the basegruvboxfrom which the others inherit. The original issue #10455 only brought upgruvbox_light, but having checked checked the rest with the change, I decided it looked good to me.gruvbox:gruvbox_dark_hard:gruvbox_dark_soft:gruvbox_light:gruvbox_light_hard:gruvbox_light_softCloses: #10455