Build exit non zero on failure #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a build failure would print the webpack errors, but exit 0 (with an unhandled promise rejection warning). Note: this was true on node 10, not sure of the other platforms.
evannoronha
suggested changes
Mar 1, 2022
hayes0724
pushed a commit
that referenced
this pull request
Mar 9, 2022
* CLI: exit 1 on error Previously, a build failure would print the webpack errors, but exit 0 (with an unhandled promise rejection warning). Note: this was true on node 10, not sure of the other platforms. * Linter fixes: throw error instead of process.exit()
github-actions bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
## [2.4.4](v2.4.3...v2.4.4) (2022-03-09) ### Bug Fixes * Build exit non zero on failure ([#153](#153)) ([8b595f9](8b595f9)) * Environment vars: allow them to work ([#184](#184)) ([009f704](009f704)) * handle {file}.css.liquid assets correctly ([0f8e0ce](0f8e0ce)), closes [#144](#144) * ssl:make timing bug ([#180](#180)) ([bec0e9e](bec0e9e))
Dejanimitrijevic
pushed a commit
to Dejanimitrijevic/shopify-packer
that referenced
this pull request
May 28, 2024
## [2.4.4](hayes0724/shopify-packer@v2.4.3...v2.4.4) (2022-03-09) ### Bug Fixes * Build exit non zero on failure ([#153](hayes0724/shopify-packer#153)) ([8b595f9](hayes0724/shopify-packer@8b595f9)) * Environment vars: allow them to work ([#184](hayes0724/shopify-packer#184)) ([009f704](hayes0724/shopify-packer@009f704)) * handle {file}.css.liquid assets correctly ([0f8e0ce](hayes0724/shopify-packer@0f8e0ce)), closes [#144](hayes0724/shopify-packer#144) * ssl:make timing bug ([#180](hayes0724/shopify-packer#180)) ([bec0e9e](hayes0724/shopify-packer@bec0e9e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a build failure would print the webpack errors, but exit 0
(with an unhandled promise rejection warning).
Note: this was true on node 10, not sure of the other platforms.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch, not themasterbranch