[BUG] style.css.liquid in assets breaks watcher #144
Comments
danielbeardsley
added a commit
to iFixit/shopify-packer
that referenced
this issue
Mar 1, 2022
somefile.css.liquid was being picked up as a "liquid" file and we assumed it definitely *wasn't* in the dist/assets dir. This is sometimes not true (we can have liquid files in the assets dir). Since the paths we get are already relative to the assets dir, let's just use path joining and normalization to handle those cases. All this function can do is exclude some files, it can't move them. So we shouldn't be trying to *create* new paths based on extensions. Fixes hayes0724#144
9 tasks
hayes0724
pushed a commit
that referenced
this issue
Mar 9, 2022
somefile.css.liquid was being picked up as a "liquid" file and we assumed it definitely *wasn't* in the dist/assets dir. This is sometimes not true (we can have liquid files in the assets dir). Since the paths we get are already relative to the assets dir, let's just use path joining and normalization to handle those cases. All this function can do is exclude some files, it can't move them. So we shouldn't be trying to *create* new paths based on extensions. Fixes #144
github-actions bot
pushed a commit
that referenced
this issue
Mar 9, 2022
## [2.4.4](v2.4.3...v2.4.4) (2022-03-09) ### Bug Fixes * Build exit non zero on failure ([#153](#153)) ([8b595f9](8b595f9)) * Environment vars: allow them to work ([#184](#184)) ([009f704](009f704)) * handle {file}.css.liquid assets correctly ([0f8e0ce](0f8e0ce)), closes [#144](#144) * ssl:make timing bug ([#180](#180)) ([bec0e9e](bec0e9e))
|
🎉 This issue has been resolved in version 2.4.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Dejanimitrijevic
pushed a commit
to Dejanimitrijevic/shopify-packer
that referenced
this issue
May 28, 2024
## [2.4.4](hayes0724/shopify-packer@v2.4.3...v2.4.4) (2022-03-09) ### Bug Fixes * Build exit non zero on failure ([#153](hayes0724/shopify-packer#153)) ([8b595f9](hayes0724/shopify-packer@8b595f9)) * Environment vars: allow them to work ([#184](hayes0724/shopify-packer#184)) ([009f704](hayes0724/shopify-packer@009f704)) * handle {file}.css.liquid assets correctly ([0f8e0ce](hayes0724/shopify-packer@0f8e0ce)), closes [#144](hayes0724/shopify-packer#144) * ssl:make timing bug ([#180](hayes0724/shopify-packer#180)) ([bec0e9e](hayes0724/shopify-packer@bec0e9e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When you put .css.liquid file in the assets it breaks the watcher (packer start) and it will not update css or js. Deploy does not have that issues.
To Reproduce
Steps to reproduce the behavior:
custom.css.liquid: no such file or directoryExpected behavior
watcher working after adding .css.liquid files to assets
System (please complete the following information):
Packer (please complete the following information):
Theme (please complete the following information):
The text was updated successfully, but these errors were encountered: