Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version file path #2846

Merged
merged 1 commit into from
May 30, 2024
Merged

fix: version file path #2846

merged 1 commit into from
May 30, 2024

Conversation

ksurl
Copy link
Contributor

@ksurl ksurl commented May 30, 2024

Proposed change

add quotes to fix file detection for on push trigger

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to this container)
  • Breaking change (fix/feature causing existing functionality to break)

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: relates to #
  • Link to documentation updated (if done separately): https://...

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated

@ksurl
Copy link
Contributor Author

ksurl commented May 30, 2024

base image build did not trigger on new transmission release (the version check workflow did update the version file in the upstream folder as expected). seems like a common mistake to not have quotes on the file path and the workflow does not pick up the files as changed.

after this is merged, it will have to be run as a manual dispatch since the file is already updated, which should also trigger a repo full build based on the new version on the dev tag.

@pkishino pkishino merged commit ff54fcc into haugene:dev May 30, 2024
@ksurl
Copy link
Contributor Author

ksurl commented May 30, 2024

@pkishino can you manually run the Transmission Builds workflow? it should make a new base image based on transmission 4.0.6 so main image dev builds will use that going forward

@ilike2burnthing
Copy link
Contributor

ilike2burnthing commented Jun 5, 2024

Quotes are not required on paths, branches, or tags, unless they start with * (possibly also ! from some testing) - https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#patterns-to-match-file-paths

The reason the subsequent action wasn't triggered is because it requires a personal access token - https://github.com/orgs/community/discussions/25702

Fixed in #2843.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants