transmission version: check with SHA & allow git push to trigger build workflow #2843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
@ksurl & @pkishino
Looking at the commits for this on the dev branch, there appear to be two problems:
4.0.5
A healthy job fetches ~25000B, whereas an unhealthy job is ~100 times less than that, so I'm guessing some sort of error page (there's no output to confirm).
Adding the additional check, that
LATEST_VERSION
isn't null or empty, should prevent these pointless bot commits.While unlikely, Transmission could publish a new build (e.g.
4.0.6
), we pull and build with it, they delete it (say because of a security hotfix), and they publish a new4.0.6
build. The workflow would not see this as a new build, and we'd be left using the vulnerable build. Switching to the commit SHA avoids this issue.Alternatively, we could use one of the following:
Published Date
Release ID
You can see the results of the workflow here:
Currently, the
git push
here does not trigger theTransmission Builds
workflow. This requires the use of a personal access token withrepo
rights, and which would need to be set up as a repository secret with the namePAT
, before committing this PR.I don't know if that would also be need for
docker-transmission-builds.yml
, in order to trigger theImage Builds
workflow, I can't test that out.Questions, comments, whatever; let me know.
Type of change
Additional information
fixes #
relates to #2691
https://...
Checklist
If user exposed functionality or configuration variables are added/changed: