Backport of UI: Changes jwks_ca_pem param to a 'file' edit type into release/1.13.x #24699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-23073/fix-uploading-pem-for-jwt-ca/usefully-precise-goblin
branch
from
cda8eac
to
b3a5c11
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
approved these changes
Jan 7, 2024
hellobontempo
deleted the
backport/ui/VAULT-23073/fix-uploading-pem-for-jwt-ca/usefully-precise-goblin
branch
|
Build Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #24697 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
Fixes hashicorp/vault-plugin-auth-jwt#248 by adding upload capabilities for the
jwks_ca_pemparam. Previously the input was a basic (single line) text input, now a user can upload a PEM certificate or paste it in a multi-line text area. The CA is submitted in the correct format now, see the screenshot below includes line breaks where expected:Overview of commits