UI: Changes jwks_ca_pem param to a 'file' edit type #24697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
commented
Jan 5, 2024
Comment on lines
+40
to
+50
| jwksUrl: attr('string', { | ||
| label: 'JWKS URL', | ||
| }), | ||
|
|
||
| oidcResponseMode: attr('string', { | ||
| label: 'OIDC response mode', | ||
| }), | ||
|
|
||
| oidcResponseTypes: attr('string', { | ||
| label: 'OIDC response types', | ||
| }), |
There was a problem hiding this comment.
While here decided to add these labels to uppercase properly. Previously they were coming in directly from openAPI and read as Jwks or Oidc
There was a problem hiding this comment.
Thank you. These small catches do a lot to increase the overall ux.
|
Build Results: |
This was referenced Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/vault-plugin-auth-jwt#248 by adding upload capabilities for the
jwks_ca_pemparam. Previously the input was a basic (single line) text input, now a user can upload a PEM certificate or paste it in a multi-line text area. The CA is submitted in the correct format now, see the screenshot below includes line breaks where expected: