Skip to content

Commit

Permalink
[release-automation] Stop adding temporary conda bin into PATH (ray-p…
Browse files Browse the repository at this point in the history
…roject#44815)

The script that verifies macos wheels installs `miniconda3` into a temporary directory, then exports its binary path `$TMP_DIR/miniconda3/bin` into `PATH`. This caused a problem when a new conda environment is created and activated, this path goes before the environment's bin path.

---------

Signed-off-by: khluu <[email protected]>
  • Loading branch information
khluu authored Apr 19, 2024
1 parent 0edfee2 commit 811030f
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions .buildkite/release-automation/verify-macos-wheels.sh
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ install_miniconda() {
bash "$TMP_DIR/miniconda3/miniconda.sh" -b -u -p "$TMP_DIR/miniconda3"
rm -rf "$TMP_DIR/miniconda3/miniconda.sh"

# Add miniconda3 to the PATH to use `conda` command.
export PATH="$TMP_DIR/miniconda3/bin:$PATH"

# Initialize conda. This replaces calling `conda init bash`.
# Conda init command requires a shell restart which should not be done on BK.
source "$TMP_DIR/miniconda3/etc/profile.d/conda.sh"
Expand Down Expand Up @@ -71,8 +68,6 @@ _clean_up() {
# Create tmp directory unique for the run
TMP_DIR="$(mktemp -d "$HOME/tmp.XXXXXXXXXX")"
mkdir -p "$TMP_DIR/bin"
# Add bin dir to the path.
export PATH="$TMP_DIR/bin:$PATH"

trap _clean_up EXIT

Expand Down

0 comments on commit 811030f

Please sign in to comment.