[release-automation] Stop adding temporary conda bin into PATH #44815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script that verifies macos wheels installs
miniconda3
into a temporary directory, then exports its binary path$TMP_DIR/miniconda3/bin
intoPATH
. This caused a problem when a new conda environment is created and activated, this path goes before the environment's bin path: https://buildkite.com/ray-project/release-automation/builds/384#018eedf8-6486-41ab-889c-2f8db37e57bd/39-286^ In this log where I
echo $PATH
after activating the conda environmentrayio_3.9
, you can see that/Users/ec2-user/tmp.PyjQ7FlK9E/miniconda3/envs/rayio_3.9/bin
is supposed to be the first in$PATH
, but it's/Users/ec2-user/tmp.PyjQ7FlK9E/miniconda3/bin
instead. This led the environment to usepython
andpip
from the default miniconda installation which is on 3.8 version: https://buildkite.com/ray-project/release-automation/builds/384#018eedf8-6486-41ab-889c-2f8db37e57bd/39-268I ran the job again without exporting and it shows that the right python and pip version from the environment was used: https://buildkite.com/ray-project/release-automation/builds/387#018eee3e-6b83-40a0-9a1b-e8164426f3e3/32-256
along with the env path being first in
$PATH
: https://buildkite.com/ray-project/release-automation/builds/387#018eee3e-6b83-40a0-9a1b-e8164426f3e3/32-274The step was able to find the right distribution from
ray
on testpypi. It only failed because the commit was not right which is expected.