Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a regression in Valueset Expansion #5993

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Fix a regression in Valueset Expansion #5993

merged 3 commits into from
Jun 8, 2024

Conversation

tadgh
Copy link
Collaborator

@tadgh tadgh commented Jun 8, 2024

A regression was introduced in #5969 causing ValueSet expansions where the property was non-standard, and the op was is-a, which caused a failure to expand. e.g. such a valueset.

{
	"resourceType": "ValueSet",
	"status": "active",
	"name": "StandardLabObsQuantitative_VSET",
	"id": "standard-lab-obs-quant-vs",
	"title": "Standard Lab Obs Quantitative value set",
	"description": "A set of LOINC codes for quantitative lab tests.",
	"version": "1.0.0",
	"url": "https://fhir.graphitehealth.io/release/4.0.1/Profiles/ValueSet/standard-lab-obs-quant-vs",
	"compose": {
		"include": [
			{
				"system": "http:https://hl7.org/fhir/CodeSystem/example",
				"filter": [
					{
						"property": "SCALE_TYP",
						"op": "is-a",
						"value": "Qn"
					}
				]
			}
		]
	}
}

Would result in HAPI-2526. This patch modifies a test valueset to exercise this failure via the testCodeInLargeValueSet method, and also corrects the incomplete switch statement.

Copy link

github-actions bot commented Jun 8, 2024

Formatting check succeeded!

@tadgh tadgh enabled auto-merge (squash) June 8, 2024 03:31
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.47%. Comparing base (497b9f2) to head (94c25d3).
Report is 87 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5993      +/-   ##
============================================
+ Coverage     83.39%   83.47%   +0.07%     
- Complexity    26927    27171     +244     
============================================
  Files          1681     1695      +14     
  Lines        103965   105042    +1077     
  Branches      13189    13302     +113     
============================================
+ Hits          86702    87680     +978     
- Misses        11613    11668      +55     
- Partials       5650     5694      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tadgh tadgh merged commit 4321670 into master Jun 8, 2024
65 of 66 checks passed
@tadgh tadgh deleted the build-fix branch June 8, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants