Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing value expansion filtered by url #5969

Merged
merged 9 commits into from
Jun 6, 2024

Conversation

TipzCM
Copy link
Collaborator

@TipzCM TipzCM commented May 27, 2024

closes #5968

Copy link

github-actions bot commented May 27, 2024

Formatting check succeeded!

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.45%. Comparing base (497b9f2) to head (c7f13cd).
Report is 84 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5969      +/-   ##
============================================
+ Coverage     83.39%   83.45%   +0.05%     
- Complexity    26927    27159     +232     
============================================
  Files          1681     1695      +14     
  Lines        103965   105019    +1054     
  Branches      13189    13298     +109     
============================================
+ Hits          86702    87642     +940     
- Misses        11613    11667      +54     
- Partials       5650     5710      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmarchionatto jmarchionatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved with a nitpick comment

@tadgh tadgh merged commit 5b75639 into master Jun 6, 2024
65 of 66 checks passed
@tadgh tadgh deleted the 5968-value-set-expansion-filtered-by-url branch June 6, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expansion of value set throws when filtering the expansion by url
3 participants