6_4 mergeback #4547
Merged
6_4 mergeback #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding initial test. * Adding fix and subsequent test. * Adding changelog. --------- Co-authored-by: peartree <[email protected]>
…atching channel be unqualified (#4464) * Adding initial test. * Adding initial solution implementation. * Adding change log and code clean up. * addressing comments from 1st code review. --------- Co-authored-by: peartree <[email protected]>
* change migration visibility * add empty migration method for 640 --------- Co-authored-by: nathaniel.doef <[email protected]>
… from an update pointcut (#4484) * First commit: Make SubscriptionValidatingInterceptor aware of which Pointcut is being called. In validatePermissions(), skip determinePartition() if the Pointcut is STORAGE_PRESTORAGE_RESOURCE_UPDATED. Fix resulting compile errors in various unit tests. * Fix/enhance unit tests. Mark methods as deprecated instead of deleting them. Add proper error code. Complete changelog. * Remove erroneous TODOs and tweak the validation logic. * Enhance unit tests and fix changelog.
* adding changelog. * Providing solution and adding changelog. * Adding new test. --------- Co-authored-by: peartree <[email protected]>
* cleaning up checkstyle files * One more fix for #4467 (#4469) * added exlusions for files at base project level so checkstyle doesn't error out * duplicate error code from merge * changing lifecycle goal for all module checkstyle check * moving checkstyle to base pom file, changing exectution phase on base check, cleaning dependency, resolving duplicate error code * wip * trying to figure out why pipeline cannot copy files * removing modules that don't actually need to be built. * I messed up the version --------- Co-authored-by: James Agnew <[email protected]>
* Bump core to 5.6.881-SNAPSHOT * Work on fixing tests * Work on fixing tests 2 * Bump to core release --------- Co-authored-by: dotasek <[email protected]>
* Extract method for readability * Save always normalized score values in POSSIBLE_MATCH links. * Avoid setting properties to null values. Adjust test. * Simplify fix * Fix test. Add RangeTestHelper. --------- Co-authored-by: juan.marchionatto <[email protected]>
This reverts commit efae3b5.
* fix bug where FINALIZE jobs are not cancellable * moved reduction step to message hander * moving reduction step to queue * addingchangelog * cleaning up * review fixes * review fix' --------- Co-authored-by: leif stawnyczy <[email protected]>
* First commit: Scheduled batch 2 bulk export job delete and binary, incomplete mock-based unit test, and a mess of TODOs and code that needs to be deleted. * Refine solution and add a concrete unit test but still work to do. * Comment out code in cancelAndPurgeAllJobs() and see if it breaks the pipeline. * Unit tests complete. New Msg code for new IJobPersistence.fetchInstances() method. Cleanup TODOs and add others. * Finish final touches on implementation. * Add changelog. * Various cleanup. * Code review feedback. * Small tweak to changelog. * Last code review tweak. * Address more code review comments. * Reverse changes to consider work chunks. Add a constant for write-to-binary.
* change tests * suggested test change
* Bump Postgres for CVE * Bump jetty * Verison bump * Remove comments * Revrt bump
* Initial implementation * better tests * Add changelog and docs * Forgotten files * Code review comments * Fix checkstyle
* changes for GL-3943 * changes for GL-3943 --------- Co-authored-by: isaacwen <[email protected]>
Providing changelog; Co-authored-by: peartree <[email protected]>
…ce (#4514) * changed what score is set for mdmlinks that created new golden resource * fix test --------- Co-authored-by: Long Ma <[email protected]>
#4527) * trying to fix BulkDataExportTest testGroupBulkExportNotInGroup_DoesNotShowUp * added change log --------- Co-authored-by: leif stawnyczy <[email protected]>
Co-authored-by: peartree <[email protected]>
…cription messages for different requests (#4524) * fix + test * minor fix * Addressing suggestion * Minor changes
* adding a test * fail in the case of ref enforce on type and on write and autocreate are all true * update to code * removing a line * cleanup * removing check on urn * changing just to trigger a build * adding a comment to the pom * updating test for better information --------- Co-authored-by: leif stawnyczy <[email protected]>
* retryCount 0 on null header + test + changelog * suggested changes
Co-authored-by: kylejule <[email protected]>
Don't log payloads - they may contain sensitive data.
* failing test * fix + changelog * tweak * add method to IJobPersistence to use a Stream * tweak * tweak * decrease test time * clean up * code review comments * version bump * Increase timeout limit to match BulkExportUseCaseTest * shorten test * maintenance pass * add logging * Revert "add logging" This reverts commit b0453fd. * Revert "maintenance pass" This reverts commit bbc7418. * test * trying to fix BulkDataExportTest testGroupBulkExportNotInGroup_DoesNotShowUp * shorten tests * logging * move test location * fixes a regression caused my change in hapi-fhir * timeout * Revert "fixes a regression caused my change in hapi-fhir" This reverts commit 4b58013. * testing * Revert "testing" This reverts commit aafc95c. --------- Co-authored-by: leif stawnyczy <[email protected]>
Closed
tadgh
approved these changes
Feb 13, 2023
Codecov ReportBase: 81.32% // Head: 81.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4547 +/- ##
============================================
+ Coverage 81.32% 81.38% +0.06%
- Complexity 23650 23854 +204
============================================
Files 1425 1432 +7
Lines 86399 87412 +1013
Branches 11677 11793 +116
============================================
+ Hits 70265 71143 +878
- Misses 10947 11029 +82
- Partials 5187 5240 +53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.