-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cleaning up checkstyle files (#4470)
* cleaning up checkstyle files * One more fix for #4467 (#4469) * added exlusions for files at base project level so checkstyle doesn't error out * duplicate error code from merge * changing lifecycle goal for all module checkstyle check * moving checkstyle to base pom file, changing exectution phase on base check, cleaning dependency, resolving duplicate error code * wip * trying to figure out why pipeline cannot copy files * removing modules that don't actually need to be built. * I messed up the version --------- Co-authored-by: James Agnew <[email protected]>
- Loading branch information
1 parent
dd8c8a3
commit efae3b5
Showing
31 changed files
with
369 additions
and
535 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
hapi-fhir-checkstyle/src/checkstyle/hapi-base-checkstyle.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
<?xml version="1.0"?> | ||
<!DOCTYPE module PUBLIC | ||
"-//Puppy Crawl//DTD Check Configuration 1.3//EN" | ||
"https://www.puppycrawl.com/dtds/configuration_1_3.dtd"> | ||
|
||
<module name="Checker"> | ||
|
||
<property name="severity" value="error"/> | ||
<property name="charset" value="UTF-8"/> | ||
<property name="fileExtensions" value="java, properties, xml, js, json"/> | ||
|
||
<module name="TreeWalker"> | ||
<!-- Run custom HapiErrorCodeCheck to find duplicate error codes --> | ||
<module name="ca.uhn.fhir.checks.HapiErrorCodeCheck"/> | ||
<!-- Throw error if any FIX ME is left in the code --> | ||
<module name="TodoComment"> | ||
<!-- The (?i) below means Case Insensitive --> | ||
<property name="format" value="(?i)FIXME"/> | ||
</module> | ||
|
||
<module name="RegexpSinglelineJava"> | ||
<property name="format" value="System\.out\.println"/> | ||
<property name="ignoreComments" value="true"/> | ||
</module> | ||
<module name="RegexpSinglelineJava"> | ||
<property name="format" value="org\.jetbrains\.annotations\.NotNull"/> | ||
</module> | ||
<module name="RegexpSinglelineJava"> | ||
<property name="format" value="org\.jetbrains\.annotations\.Nullable"/> | ||
</module> | ||
<!-- Should always use the Spring transactional interface, per: https://stackoverflow.com/questions/26387399/javax-transaction-transactional-vs-org-springframework-transaction-annotation-tr --> | ||
<module name="RegexpSinglelineJava"> | ||
<property name="format" value="javax\.transaction\.Transactional"/> | ||
<property name="message" | ||
value="Wrong @Transactional annotation used, use instead: org.springframework.transaction.annotation.Transactional"/> | ||
</module> | ||
<module name="AbstractClassName"> | ||
<property name="format" value="^(Base|Abstract).+$"/> | ||
</module> | ||
</module> | ||
</module> |
Oops, something went wrong.