Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce OperationParamater min/max constraints #4409

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −0
Open

Enforce OperationParamater min/max constraints #4409

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be6f5a2
check number of values supplied for an OperationParamater fits min/ma…
lawley Jan 6, 2023
e8c2320
interpret myMax < 0 as no upper bound
lawley Jan 15, 2023
8086e3e
Include new error codes in Exceptions
lawley Jan 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
check number of values supplied for an OperationParamater fits min/ma… 
…x constraints
  • Loading branch information
@lawley
lawley committed Jan 6, 2023
commit be6f5a2ce406c497c7e5c7d18c1aa5e0e4c1c40e
7 changes: 7 additions & 0 deletions hapi-fhir-server/src/main/java/ca/uhn/fhir/rest/server/method/OperationParameter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,13 @@ public Object translateQueryParametersIntoServerArgument(RequestDetails theReque
return null;
}

if (matchingParamValues.size() > myMax) {
throw new InvalidRequestException("Too many " + myName + " parameters. Got " + matchingParamValues.size() + " but only " + myMax + " allowed.");
}
if (matchingParamValues.size() < myMin) {
throw new InvalidRequestException("Missing " + myName + " parameters. Got " + matchingParamValues.size() + " but need at least " + myMax);
}

if (myInnerCollectionType == null) {
return matchingParamValues.get(0);
}
Expand Down