Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce OperationParamater min/max constraints #4409

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lawley
Copy link
Contributor

@lawley lawley commented Jan 6, 2023

check number of values supplied for an OperationParamater fits min/max constraints
throw BadRequest if constraint is violated

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Base: 81.00% // Head: 81.32% // Increases project coverage by +0.32% 🎉

Coverage data is based on head (8086e3e) compared to base (02944ba).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4409      +/-   ##
============================================
+ Coverage     81.00%   81.32%   +0.32%     
- Complexity    23466    23615     +149     
============================================
  Files          1446     1420      -26     
  Lines         86175    86298     +123     
  Branches      11798    11673     -125     
============================================
+ Hits          69809    70185     +376     
+ Misses        11087    10929     -158     
+ Partials       5279     5184      -95     
Impacted Files Coverage Δ
...validation/validator/VersionTypeAdvisorDstu21.java 0.00% <0.00%> (-100.00%) ⬇️
...ir/jpa/provider/r4/BaseResourceProviderR4Test.java 0.00% <0.00%> (-95.32%) ⬇️
ca/uhn/fhir/mdm/api/IMdmLink.java 42.85% <0.00%> (-28.58%) ⬇️
...uhn/fhir/jpa/term/config/TermCodeSystemConfig.java 75.00% <0.00%> (-25.00%) ⬇️
...a/mdm/svc/candidate/FindCandidateByExampleSvc.java 66.66% <0.00%> (-22.23%) ⬇️
...a/uhn/fhir/jpa/mdm/svc/MdmLinkQuerySvcImplSvc.java 66.66% <0.00%> (-20.84%) ⬇️
...bscription/channel/impl/LinkedBlockingChannel.java 72.72% <0.00%> (-17.28%) ⬇️
...model/entity/ResourceIndexedComboStringUnique.java 56.75% <0.00%> (-16.22%) ⬇️
...hir/rest/server/servlet/ServletRequestDetails.java 73.56% <0.00%> (-15.84%) ⬇️
ca/uhn/fhir/jpa/test/config/TestJPAConfig.java 87.50% <0.00%> (-12.50%) ⬇️
... and 319 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant