Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:nickname Qualifier Support for Custom SearchParameters #3969

Merged
merged 10 commits into from
Sep 7, 2022
Merged

:nickname Qualifier Support for Custom SearchParameters #3969

merged 10 commits into from
Sep 7, 2022

Conversation

nathandoef
Copy link
Collaborator

@nathandoef nathandoef commented Aug 29, 2022 •
edited
Loading

  • Support for the :nickname qualifier has been added for custom SearchParameters

@nathandoef nathandoef changed the title - add failing test Allow Nickname Expansion for Custom SearchParameters Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022 •
edited
Loading

Codecov Report

Merging #3969 (6f9b6a1) into master (e7a4c49) will decrease coverage by 1.65%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3969      +/-   ##
============================================
- Coverage     81.86%   80.20%   -1.66%     
- Complexity    20838    22492    +1654     
============================================
  Files          1421     1441      +20     
  Lines         77246    83328    +6082     
  Branches      11078    11644     +566     
============================================
+ Hits          63236    66832    +3596     
- Misses         9866    11445    +1579     
- Partials       4144     5051     +907
Impacted Files Coverage Δ
...-fhir-base/src/main/java/ca/uhn/fhir/i18n/Msg.java
...n/java/ca/uhn/fhir/parser/ErrorHandlerAdapter.java
...e/src/main/java/ca/uhn/fhir/parser/JsonParser.java
...n/java/ca/uhn/fhir/parser/LenientErrorHandler.java
...ain/java/ca/uhn/fhir/parser/ParseErrorHandler.java
.../src/main/java/ca/uhn/fhir/parser/ParserState.java
...in/java/ca/uhn/fhir/parser/StrictErrorHandler.java
...ava/ca/uhn/fhir/parser/json/BaseJsonLikeArray.java
...va/ca/uhn/fhir/parser/json/BaseJsonLikeObject.java
...ava/ca/uhn/fhir/parser/json/BaseJsonLikeValue.java
... and 2843 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nathandoef nathandoef linked an issue Aug 30, 2022 that may be closed by this pull request
:nickname Qualifier Does Not Work On Custom SearchParameters #3972
Closed
@nathandoef nathandoef changed the title Allow Nickname Expansion for Custom SearchParameters :nickname Qualifier Support for Custom SearchParameters Aug 31, 2022
tadgh
tadgh approved these changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending minor change

hapi-fhir-base/src/main/java/ca/uhn/fhir/rest/param/StringParam.java Outdated Show resolved Hide resolved
...n/hapi/fhir/changelog/6_2_0/3972-nickname-qualifier-support-for-custom-searchparameters.yaml Outdated Show resolved Hide resolved
...st-r4/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderCustomSearchParamR4Test.java Show resolved Hide resolved
@tadgh tadgh enabled auto-merge (squash) September 2, 2022 17:53
@tadgh tadgh disabled auto-merge September 2, 2022 17:53
@tadgh tadgh merged commit 9b50b33 into master Sep 7, 2022
@tadgh tadgh deleted the nd-kj-nickname-qualifier-with-custom-search-param branch September 7, 2022 15:52
michaelabuckley added a commit that referenced this pull request Sep 20, 2022
@michaelabuckley
Merge commit '14253dd0e3112721692fb98a94a54922a4177ac4' into mb-compo…
caa803f 
…site-sp-hsearch

* commit '14253dd0e3112721692fb98a94a54922a4177ac4': (41 commits)
  3960 when creating a resource patient where patientmetasource is provided with a hash the hash value is overwritten (#3965)
  Rel 6 1 2 mergeback (#4033)
  change search method for missing parameter names (#3982)
  removed library immunizationCQLLibrary (#4024)
  #3738 renamed patient parameter to subject (#4019)
  Avoid NPE when run in IJ (#4018)
  Add disabled test reproducing open bug (#3994)
  ForcedOffsetSearchModeInterceptor should not modify the search when it is already manually marked as synchronous (#4016)
  Iam opensearch auth (#4011)
  Broken bulk export (#4012)
  Handling unexpected response status code of import-poll-status operation (#3939)
  Rel 6 1 1 mergeback (#4004)
  3984 rework immunization cql unit test (#4005)
  Issue 3419 elastic search exception while pre expanding valueset with more than 10 000 concepts (#3991)
  :nickname Qualifier Support for Custom SearchParameters (#3969)
  Ensure HS before attempting fulltext reindex.   (#3995)
  Everything operation with type param code review fixes (#3926)
  update azure-pipelines.yml to match projects that have tests (#3993)
  Fixed the issue of bulk export returning the wrong path if "Fixed Value for Endpoint Base URL" is set (#3958)
  Add support for ICD-10 International Version (Fixes #3734) (#3849)
  ...

# Conflicts:
#	hapi-fhir-jpaserver-elastic-test-utilities/src/test/resources/logback-test.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadgh tadgh tadgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

:nickname Qualifier Does Not Work On Custom SearchParameters
2 participants
@nathandoef @tadgh