3960 when creating a resource patient where patientmetasource is provided with a hash the hash value is overwritten #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Meta source id is not replaced if provided. -Added change log.
|
This pull request introduces 1 alert when merging 2eb7ba9 into 5509bd0 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 4cb6443 into 506966e - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #3965 +/- ##
============================================
- Coverage 81.86% 80.23% -1.63%
- Complexity 20838 22514 +1676
============================================
Files 1421 1442 +21
Lines 77246 83456 +6210
Branches 11078 11645 +567
============================================
+ Hits 63236 66961 +3725
- Misses 9866 11440 +1574
- Partials 4144 5055 +911 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This pull request introduces 1 alert when merging 81427ce into f3e6837 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging dfe39f6 into ec5a6ad - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging c9f8e07 into c647154 - view on LGTM.com new alerts:
|
epeartree
reviewed
Sep 8, 2022
hapi-fhir-storage/src/main/java/ca/uhn/fhir/jpa/api/config/DaoConfig.java
Outdated
Show resolved
Hide resolved
epeartree
reviewed
Sep 8, 2022
...aserver-test-utilities/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4Test.java
Outdated
Show resolved
Hide resolved
epeartree
reviewed
Sep 8, 2022
...aserver-test-utilities/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4Test.java
Outdated
Show resolved
Hide resolved
epeartree
reviewed
Sep 8, 2022
...aserver-test-utilities/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4Test.java
Outdated
Show resolved
Hide resolved
epeartree
reviewed
Sep 8, 2022
...aserver-test-utilities/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4Test.java
Outdated
Show resolved
Hide resolved
epeartree
reviewed
Sep 8, 2022
...aserver-test-utilities/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4Test.java
Outdated
Show resolved
Hide resolved
epeartree
reviewed
Sep 8, 2022
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java
Show resolved
Hide resolved
epeartree
reviewed
Sep 8, 2022
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java
Show resolved
Hide resolved
epeartree
reviewed
Sep 8, 2022
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java
Show resolved
Hide resolved
epeartree
reviewed
Sep 8, 2022
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java
Outdated
Show resolved
Hide resolved
epeartree
reviewed
Sep 8, 2022
...aserver-test-utilities/src/test/java/ca/uhn/fhir/jpa/provider/r4/ResourceProviderR4Test.java
Outdated
Show resolved
Hide resolved
epeartree
reviewed
Sep 8, 2022
...e-patient-where-patientmetasource-is-provided-with-a-hash-the-hash-value-is-overwritten.yaml
Outdated
Show resolved
Hide resolved
epeartree
requested changes
Sep 9, 2022
epeartree
reviewed
Sep 9, 2022
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java
Outdated
Show resolved
Hide resolved
…a-resource-patient-where-patientmetasource-is-provided-with-a-hash-the-hash-value-is-overwritten
StevenXLi
reviewed
Sep 12, 2022
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java
Outdated
Show resolved
Hide resolved
epeartree
approved these changes
Sep 16, 2022
StevenXLi
approved these changes
Sep 16, 2022
michaelabuckley
added a commit
that referenced
this pull request
Sep 20, 2022
…site-sp-hsearch * commit '14253dd0e3112721692fb98a94a54922a4177ac4': (41 commits) 3960 when creating a resource patient where patientmetasource is provided with a hash the hash value is overwritten (#3965) Rel 6 1 2 mergeback (#4033) change search method for missing parameter names (#3982) removed library immunizationCQLLibrary (#4024) #3738 renamed patient parameter to subject (#4019) Avoid NPE when run in IJ (#4018) Add disabled test reproducing open bug (#3994) ForcedOffsetSearchModeInterceptor should not modify the search when it is already manually marked as synchronous (#4016) Iam opensearch auth (#4011) Broken bulk export (#4012) Handling unexpected response status code of import-poll-status operation (#3939) Rel 6 1 1 mergeback (#4004) 3984 rework immunization cql unit test (#4005) Issue 3419 elastic search exception while pre expanding valueset with more than 10 000 concepts (#3991) :nickname Qualifier Support for Custom SearchParameters (#3969) Ensure HS before attempting fulltext reindex. (#3995) Everything operation with type param code review fixes (#3926) update azure-pipelines.yml to match projects that have tests (#3993) Fixed the issue of bulk export returning the wrong path if "Fixed Value for Endpoint Base URL" is set (#3958) Add support for ICD-10 International Version (Fixes #3734) (#3849) ... # Conflicts: # hapi-fhir-jpaserver-elastic-test-utilities/src/test/resources/logback-test.xml
michaelabuckley
added a commit
that referenced
this pull request
Sep 23, 2022
* commit '6f80206776bf1f3bf46576d8c457c7e9d2009f29': Fix transactional issue in everything operation (#4063) changed the comment in Msg class (#4061) Revert "changed the comment in Msg class, and added changelog (#4049)" (#4059) changed the comment in Msg class, and added changelog (#4049) Add test and changelog (#4039) Add changelog, test, and implementation (#4055) changing fetch depth to 1 (#4056) Change hsearch to consider unquoted parameter strings as prefix match (#4045) Fix content negotiation on binary streaming (#4053) fix-matchers-not-contains-in-asserts (#3913) 3929 batch2 jobs file fetching step strict policy for response header content type (#3945) 4030 bulk export to support fhir basepatientid$export endpoint (#4032) SMILE-3459 Implemented -l parameter in validator. (#3983) Skip resource updating completely if found in package load. (#4036) Add :text handling to StringParam (#4047) 3960 when creating a resource patient where patientmetasource is provided with a hash the hash value is overwritten (#3965) Rel 6 1 2 mergeback (#4033)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done:
-Whether the submitted request id will be preserved now depends on the configuration.
-Added new test to check request id replacement.
-Added change log.