Skip to content

Commit

Permalink
Restore valgrind suppressions file
Browse files Browse the repository at this point in the history
contrib/valgrind-julia.supp was removed in JuliaLang#38970, but it is still referenced
[in the Valgrind devdocs](https://docs.julialang.org/en/v1/devdocs/valgrind/).
Either the file should be restored, or the reference should be removed
from the documentation.

Here, I have chosen the option of restoring the file, as I think it
provides some value.  I have also updated it such that it does indeed
suppress the warning (JuliaLang#4533) on the latest master.
  • Loading branch information
garrison committed Dec 3, 2021
1 parent ed9ad60 commit 0130f65
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions contrib/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,4 @@ Debugging
| Name | Description |
| ------------------------------ | ----------------------------------------------------------- |
|[ debug_bootstrap.gdb ](https://github.com/JuliaLang/julia/blob/master/contrib/debug_bootstrap.gdb) | Bootstrap process using the debug build |
|[ valgrind-julia.supp ](https://github.com/JuliaLang/julia/blob/master/contrib/valgrind-julia.supp) | Suppressions for Valgrind debugging tool |
10 changes: 10 additions & 0 deletions contrib/valgrind-julia.supp
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# https://github.com/JuliaLang/julia/issues/4533
{
msync unwind
Memcheck:Param
write(buf)
...
fun:validate_mem
...
fun:rec_backtrace
}

0 comments on commit 0130f65

Please sign in to comment.