Remove stale contrib files #38970
Merged
Remove stale contrib files #38970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's not remove it just yet; I may need it in 1.7. If not, we can remove it then. |
staticfloat
approved these changes
Dec 23, 2020
|
Win 32 failure looks odd |
|
It's a network failure, don't worry too much about it. |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
|
Why was EDIT: I just ran under valgrind with no suppression file, and I did not see the single warning that appeared in that suppression file, so maybe it is indeed no longer necessary... |
garrison
added a commit
to garrison/julia
that referenced
this pull request
Dec 3, 2021
contrib/valgrind-julia.supp was removed in JuliaLang#38970, but it is still referenced [in the Valgrind devdocs](https://docs.julialang.org/en/v1/devdocs/valgrind/). Either the file should be restored, or the reference should be removed from the documentation. Here, I have chosen the option of restoring the file, as I think it provides some value. I have also updated it such that it does indeed suppress the warning (JuliaLang#4533) on the latest master.
|
I have opened a PR that brings back (an updated version of) |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
contrib/valgrind-julia.supp was removed in JuliaLang#38970, but it is still referenced [in the Valgrind devdocs](https://docs.julialang.org/en/v1/devdocs/valgrind/). Either the file should be restored, or the reference should be removed from the documentation. Here, I have chosen the option of restoring the file, as I think it provides some value. I have also updated it such that it does indeed suppress the warning (JuliaLang#4533) on the latest master.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
contrib/valgrind-julia.supp was removed in JuliaLang#38970, but it is still referenced [in the Valgrind devdocs](https://docs.julialang.org/en/v1/devdocs/valgrind/). Either the file should be restored, or the reference should be removed from the documentation. Here, I have chosen the option of restoring the file, as I think it provides some value. I have also updated it such that it does indeed suppress the warning (JuliaLang#4533) on the latest master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup-libstdc++ isn't being used anymore as well, is BB perhaps using this or is it also safe to remove?