refactor: reuse random filename in filesystem image provider #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yukaii
force-pushed
the
refactor/reuse-random-filename
branch
from
8d81cc6
to
c5e2452
Compare
jackycute
reviewed
Jun 5, 2024
lib/imageRouter/filesystem.js
Outdated
| @@ -47,7 +29,7 @@ exports.uploadImage = function (imagePath, callback) { | |||
|
|
|||
| let filename = path.basename(imagePath) | |||
| try { | |||
| filename = pickFilename(path.basename(imagePath)) | |||
| filename = randomFilename() | |||
There was a problem hiding this comment.
the filename will no longer with file extension (.png), we should modify pickFilename function and only use randomFilename their without default filename.
Yukaii
force-pushed
the
refactor/reuse-random-filename
branch
from
c5e2452
to
12ed4f5
Compare
jackycute
reviewed
Jun 5, 2024
jackycute
approved these changes
Jun 5, 2024
…omness Signed-off-by: Yukai Huang <[email protected]>
Co-authored-by: Max Wu <[email protected]> Signed-off-by: Yukai Huang <[email protected]>
Yukaii
force-pushed
the
refactor/reuse-random-filename
branch
from
0dcb1a9
to
5eb3591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.