refactor: reuse random filename in filesystem image provider

Signed-off-by: Yukai Huang <[email protected]>

lib/imageRouter/filesystem.js

@@ -16,24 +16,6 @@ function randomFilename () {
  return `upload_${buf.toString('hex')}`
 }
 
-/**
- * pick a filename not exist in filesystem
- * maximum attempt 5 times
- */
-function pickFilename (defaultFilename) {
- let retryCounter = 5
- let filename = defaultFilename
- const extname = path.extname(defaultFilename)
- while (retryCounter-- > 0) {
- if (fs.existsSync(path.join(config.uploadsPath, filename))) {
- filename = `${randomFilename()}${extname}`
- continue
- }
- return filename
- }
- throw new Error('file exists.')
-}
-
 exports.uploadImage = function (imagePath, callback) {
  if (!imagePath || typeof imagePath !== 'string') {
  callback(new Error('Image path is missing or wrong'), null)
@@ -47,7 +29,7 @@ exports.uploadImage = function (imagePath, callback) {
 
  let filename = path.basename(imagePath)
  try {
- filename = pickFilename(path.basename(imagePath))
+ filename = randomFilename()
  } catch (e) {
  return callback(e, null)
  }