-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error happened when s3's provider is not aws "Unable to connect to instance metadata service" #1761
Comments
blademainer
added a commit
to blademainer/codimd
that referenced
this issue
May 6, 2022
blademainer
added a commit
to blademainer/codimd
that referenced
this issue
May 6, 2022
blademainer
added a commit
to blademainer/codimd
that referenced
this issue
May 6, 2022
Signed-off-by: blademainer <[email protected]>
blademainer
added a commit
to blademainer/codimd
that referenced
this issue
May 6, 2022
Signed-off-by: blademainer <[email protected]>
edgarogh
pushed a commit
to WartaPoirier-corp/codimd
that referenced
this issue
Jun 7, 2022
Fixes hackmdio#1761 Signed-off-by: David Mehren <[email protected]>
jackycute
added a commit
that referenced
this issue
Jan 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When s3's api is not provided by AWS(say, googlecloud, azure), an error would happen. because the endpoint-url is overwrited by the
region
conditional judgment:codimd/lib/imageRouter/s3.js
Lines 51 to 57 in a41c4db
my suggest code to fix this bug:
The text was updated successfully, but these errors were encountered: