s3 support multiple cloud providers: hackmdio#1761

blademainer · May 6, 2022 · d4bed6d · d4bed6d
1 parent ce1b1cc
commit d4bed6d
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/lib/imageRouter/s3.js b/lib/imageRouter/s3.js
@@ -48,13 +48,16 @@ exports.uploadImage = function (imagePath, callback) {
     const command = new PutObjectCommand(params)
 
     s3.send(command).then(data => {
-      let s3Endpoint = 's3.amazonaws.com'
+      // default settings to https scheme
+      let s3Endpoint = 'https://s3.amazonaws.com'
+      if (config.s3.region && config.s3.region !== 'us-east-1') {
+        s3Endpoint = `s3-${config.s3.region}.amazonaws.com`
+      }
+      // rewrite endpoint from config
       if (config.s3.endpoint) {
         s3Endpoint = config.s3.endpoint
-      } else if (config.s3.region && config.s3.region !== 'us-east-1') {
-        s3Endpoint = `s3-${config.s3.region}.amazonaws.com`
       }
-      callback(null, `https://${s3Endpoint}/${config.s3bucket}/${params.Key}`)
+      callback(null, `${s3Endpoint}/${config.s3bucket}/${params.Key}`)
     }).catch(err => {
       if (err) {
         callback(new Error(err), null)